| Time |
Nick |
Message |
| 00:32 |
|
epod joined #minetest-dev |
| 00:34 |
|
TC01 joined #minetest-dev |
| 00:36 |
|
Wuzzy joined #minetest-dev |
| 00:42 |
|
kaeza joined #minetest-dev |
| 00:56 |
|
kaeza joined #minetest-dev |
| 00:58 |
p_gimeno |
I'm confused about the braces policy regarding single statements |
| 00:58 |
p_gimeno |
I thought they should be omitted |
| 01:27 |
|
Miner_48er joined #minetest-dev |
| 01:41 |
|
fluxflux joined #minetest-dev |
| 01:47 |
|
Cornelia joined #minetest-dev |
| 02:47 |
|
Ruslan1 joined #minetest-dev |
| 02:55 |
ANAND |
They should unless there's a single statement if block and a multi-statement else block or smth. |
| 02:55 |
ANAND |
should be omitted* |
| 02:56 |
|
Ruslan1 joined #minetest-dev |
| 05:47 |
|
indiana joined #minetest-dev |
| 06:28 |
|
ssieb joined #minetest-dev |
| 07:30 |
|
ssieb joined #minetest-dev |
| 07:33 |
|
kaeza joined #minetest-dev |
| 08:15 |
|
Niwla joined #minetest-dev |
| 08:20 |
|
Niwla23 joined #minetest-dev |
| 08:23 |
|
karamel joined #minetest-dev |
| 08:30 |
ANAND |
p_gimeno: I tested your patch - it works nicely! :) |
| 08:30 |
|
ensonic joined #minetest-dev |
| 08:31 |
ANAND |
the auto_rot_attached one |
| 08:31 |
ANAND |
Shall I make a PR to upstream? |
| 08:31 |
Niwla23 |
can you see the message? |
| 08:32 |
Niwla23 |
Whats about a protocol on linux for contentDB? So you can install it from your webbrowser to minetest without extracting, copying, renaming and all this shit. |
| 08:32 |
Niwla23 |
sth. like apturl (https://wiki.ubuntuusers.de/apturl/) |
| 08:55 |
|
Niwla23 joined #minetest-dev |
| 08:57 |
|
Niwla joined #minetest-dev |
| 09:00 |
|
karamel_ joined #minetest-dev |
| 09:03 |
|
Niwla joined #minetest-dev |
| 09:03 |
|
Niwla left #minetest-dev |
| 09:03 |
|
Niwla joined #minetest-dev |
| 09:09 |
|
kaeptmblaubaer joined #minetest-dev |
| 09:16 |
|
kaeptmblaubaer joined #minetest-dev |
| 09:19 |
|
Fixer joined #minetest-dev |
| 09:25 |
|
Beton joined #minetest-dev |
| 09:27 |
|
Niwla23 joined #minetest-dev |
| 09:28 |
Niwla23 |
hello |
| 09:28 |
Niwla23 |
yeah, it is working |
| 10:26 |
|
proller joined #minetest-dev |
| 10:46 |
|
proller joined #minetest-dev |
| 11:17 |
|
proller joined #minetest-dev |
| 11:19 |
p_gimeno |
ANAND: feel free, yeah, but note the caveat |
| 11:21 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:16 |
|
Wuzzy joined #minetest-dev |
| 12:16 |
|
kaeza joined #minetest-dev |
| 12:37 |
|
Niwla23 joined #minetest-dev |
| 13:17 |
ANAND |
p_gimeno: The caveat of automatic_rotation not working when attached? |
| 13:17 |
p_gimeno |
the problems when tested attached rotation on a character |
| 13:18 |
p_gimeno |
"However, when attached to the player's arm, for some reason the object switches arm during a frame several times for a while." |
| 13:19 |
p_gimeno |
this seems to happen as you walk, when the arm is at its cusp, but as you keep walking this effect disappears, until you stop and start walking again |
| 14:15 |
ANAND |
Ah that |
| 14:16 |
ANAND |
Could it be a problem with the name of the bones or smth? |
| 14:16 |
ANAND |
Of the model's armature |
| 14:18 |
|
proller joined #minetest-dev |
| 14:20 |
p_gimeno |
it looks like an engine issue, no idea why |
| 14:43 |
|
Ruslan1 joined #minetest-dev |
| 15:13 |
ANAND |
#8466 |
| 15:14 |
ShadowBot |
https://github.com/minetest/minetest/issues/8466 -- InvRef: Add convenience method add_list for bulk transfer of items by ClobberXD |
| 15:14 |
ANAND |
rubenwardy: ^ :) |
| 15:14 |
rubenwardy |
oh cool |
| 15:17 |
ANAND |
Should I also add a `room_for_list` method to go with that? |
| 16:03 |
|
proller joined #minetest-dev |
| 16:51 |
|
twoelk joined #minetest-dev |
| 17:05 |
|
kaeza joined #minetest-dev |
| 17:10 |
|
ensonic joined #minetest-dev |
| 17:55 |
|
ssieb joined #minetest-dev |
| 18:06 |
|
twoelk left #minetest-dev |
| 18:08 |
|
proller joined #minetest-dev |
| 18:43 |
rubenwardy |
we should probably have a rule which is like "code style reviews are stupid, that's what the reviews are for. Look for real issues first" |
| 18:43 |
rubenwardy |
oops |
| 18:43 |
rubenwardy |
"code style reviews are stupid, that's what the tools are for. Look for real issues first" |
| 18:48 |
nerzhul |
linter is here to prvent that if we just use it correctly :p |
| 18:52 |
rubenwardy |
yeah |
| 18:52 |
rubenwardy |
updated #8383 |
| 18:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/8383 -- Add formspec styling using a style[] tag by rubenwardy |
| 19:07 |
p_gimeno |
if single statements should be surrounded by braces, the example in the style guide probably needs to be fixed |
| 19:08 |
rubenwardy |
imo they should be |
| 19:08 |
rubenwardy |
but the code style isn't that |
| 19:09 |
rubenwardy |
I think what paramat meant is "If one branch of an if-[elseif]-else block contains braces, all must contain braces" |
| 19:09 |
rubenwardy |
ie if { one } else { many } instead of if one else { many } |
| 19:10 |
rubenwardy |
this isn't covered in the code style |
| 19:10 |
rubenwardy |
and isn't a rule at all |
| 19:10 |
p_gimeno |
I think I can cite one or more PRs where contributors were directed to remove the braces in only one of the branches because it was single statement |
| 19:11 |
rubenwardy |
I think braces should always be required in if-statements, because it's more consistent and avoid abiguity |
| 19:11 |
rubenwardy |
but minetest's code style doesn't agree with that |
| 19:13 |
p_gimeno |
I was thinking about #8455 in particular, it confused me to be requested to add braces... I thought that the reason to add them to the else branch was the comment, that sorta kinda counted like a statement |
| 19:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/8455 -- Fix regression in automatic_face_movement_max_rotation_per_sec by paramat |
| 19:15 |
rubenwardy |
maybe |
| 19:15 |
p_gimeno |
but then when the other branch became single statement, I removed them from that one and that was also wrong |
| 19:29 |
|
Ruslan1 joined #minetest-dev |
| 19:35 |
rubenwardy |
merging #8368 in 10 |
| 19:35 |
ShadowBot |
https://github.com/minetest/minetest/issues/8368 -- Add node field to PlayerHPChangeReason table by pauloue |
| 19:36 |
|
ensonic joined #minetest-dev |
| 19:46 |
rubenwardy |
will merge #6814 after dinner |
| 19:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/6814 -- Add IrrLicht-specific smart pointer by numberZero |
| 20:38 |
|
proller joined #minetest-dev |
| 20:51 |
|
JDCodeIt joined #minetest-dev |
| 21:50 |
|
pauloue joined #minetest-dev |
| 22:15 |
|
Fixer joined #minetest-dev |
| 22:50 |
|
Calinou joined #minetest-dev |
| 22:54 |
|
pauloue joined #minetest-dev |
| 23:08 |
|
benrob0329 joined #minetest-dev |
| 23:19 |
|
Calinou joined #minetest-dev |
| 23:27 |
|
fluxflux joined #minetest-dev |
| 23:27 |
|
Taoki joined #minetest-dev |
| 23:27 |
|
VanessaE joined #minetest-dev |
| 23:27 |
|
cheapie joined #minetest-dev |
| 23:37 |
|
ANAND joined #minetest-dev |
| 23:56 |
|
kaeza joined #minetest-dev |
