| Time |
Nick |
Message |
| 00:20 |
|
ANAND joined #minetest-dev |
| 00:28 |
paramat |
making a PR |
| 00:41 |
paramat |
#9031 |
| 00:41 |
ShadowBot |
https://github.com/minetest/minetest/issues/9031 -- Fix isDead()/autoforward crash with a temporary workaround by paramat |
| 01:07 |
|
d__ joined #minetest-dev |
| 01:09 |
|
Kimapr joined #minetest-dev |
| 01:15 |
|
nepugia joined #minetest-dev |
| 01:59 |
|
nepugia_ joined #minetest-dev |
| 04:33 |
|
ensonic joined #minetest-dev |
| 04:56 |
|
ensonic joined #minetest-dev |
| 05:19 |
ANAND |
Here's a more proper solution for #9031: https://github.com/minetest/minetest/pull/9031#issuecomment-539768241 |
| 05:19 |
ShadowBot |
https://github.com/minetest/minetest/issues/9031 -- Fix isDead()/autoforward crash with a temporary workaround by paramat |
| 06:48 |
|
Foz joined #minetest-dev |
| 07:40 |
|
flux__ joined #minetest-dev |
| 07:51 |
|
Darcidride joined #minetest-dev |
| 08:38 |
|
ShadowNinja joined #minetest-dev |
| 08:43 |
|
ensonic joined #minetest-dev |
| 09:28 |
|
Wuzzy joined #minetest-dev |
| 11:06 |
|
Darcidride joined #minetest-dev |
| 12:31 |
|
T4im joined #minetest-dev |
| 12:50 |
|
Fixer joined #minetest-dev |
| 12:54 |
|
kilbith joined #minetest-dev |
| 12:55 |
kilbith |
`animated_image[]` is ready to go: #9032 |
| 12:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/9032 -- GUIFormspecMenu: Add animated_image[] element by kilbith |
| 13:51 |
|
Lia joined #minetest-dev |
| 13:52 |
|
BuckarooBanzai7 joined #minetest-dev |
| 13:55 |
|
Foz joined #minetest-dev |
| 13:55 |
|
basxto joined #minetest-dev |
| 13:55 |
|
celeron55_ joined #minetest-dev |
| 13:55 |
|
NoctisLabs joined #minetest-dev |
| 13:56 |
|
Vadtec joined #minetest-dev |
| 13:56 |
|
TC01 joined #minetest-dev |
| 13:57 |
|
Darcidride joined #minetest-dev |
| 13:58 |
|
Amaz joined #minetest-dev |
| 14:00 |
|
dzho joined #minetest-dev |
| 14:02 |
|
kilbith_ joined #minetest-dev |
| 14:11 |
|
Kimapr joined #minetest-dev |
| 14:25 |
|
tomraceror joined #minetest-dev |
| 14:29 |
|
Icedream joined #minetest-dev |
| 15:00 |
|
nepugia joined #minetest-dev |
| 15:08 |
|
ensonic joined #minetest-dev |
| 15:25 |
|
ensonic joined #minetest-dev |
| 15:36 |
|
Icedream joined #minetest-dev |
| 15:48 |
|
tomraceror joined #minetest-dev |
| 15:49 |
|
ensonic joined #minetest-dev |
| 16:22 |
|
paramat joined #minetest-dev |
| 16:25 |
paramat |
sfan5 shall i use this patch for the PR? https://github.com/minetest/minetest/pull/9031#issuecomment-539768241 |
| 16:25 |
sfan5 |
yes that looks like the proper fix for this issue |
| 16:29 |
paramat |
ok will do |
| 16:36 |
|
Lone_Wolf joined #minetest-dev |
| 16:49 |
|
ensonic joined #minetest-dev |
| 16:57 |
|
Krock joined #minetest-dev |
| 16:57 |
|
Fixer_ joined #minetest-dev |
| 17:02 |
paramat |
ok PR updated and tested |
| 17:12 |
paramat |
found a bug, but probably not a blocker #9033 |
| 17:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/9033 -- Segfault when exiting from world to menu when driving a MTG boat |
| 17:50 |
Krock |
fixing it .... |
| 17:50 |
Krock |
2 lines if lucky |
| 17:50 |
Krock |
lol |
| 17:55 |
Krock |
will push fix https://krock-works.uk.to/u/patches/0012-ContentCAO-Fix-segfault-on-quit-attached.patch in 15 minutes |
| 17:57 |
paramat |
'Mark object as gone (if) children try to detach'? comment reads a little awkwardly |
| 17:57 |
paramat |
and thanks |
| 17:59 |
paramat |
or 'for when children try to detach'? i do not understand the comment |
| 18:02 |
Krock |
* // Object must be marked as gone when children try to detach |
| 18:03 |
|
flux__ joined #minetest-dev |
| 18:04 |
p_gimeno |
hmm, why is that a problem? are other destructors using previous objects? |
| 18:05 |
Krock |
yes |
| 18:05 |
Krock |
getActiveObject() is called inside a function that is called by the destructor |
| 18:05 |
|
celeron55_ joined #minetest-dev |
| 18:05 |
p_gimeno |
I see, well spotted |
| 18:07 |
paramat |
new comment is good, go ahead |
| 18:10 |
Krock |
pushing |
| 18:10 |
Krock |
200 |
| 18:21 |
sfan5 |
Krock: if the weblate webinterface returns up-to-date translation files why not use those for this release? |
| 18:21 |
sfan5 |
then we can get the release out with the correct translations and worry about broken weblate afterwards |
| 18:24 |
Krock |
the zip archive returns outdated ones, or did you find a link for them all? |
| 18:24 |
Krock |
else we'd need to write a script to download each individual file |
| 18:28 |
|
kilbith joined #minetest-dev |
| 18:33 |
kilbith |
seeing the clang whitelist length I really wonder why clang-format is still effective |
| 18:34 |
kilbith |
it's like, pretty much all files are whitelisted, lol |
| 18:39 |
paramat |
merging #9031 |
| 18:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/9031 -- Fix isDead()/autoforward crash by paramat |
| 18:45 |
Krock |
irrlicht stuff is whitelisted for sure, and most files have trivial code style issues where turning it on wouldn't yet make sense |
| 18:46 |
sfan5 |
Krock: I didn't try myself, just read your comemnt that said there was a way to get the updated files |
| 18:46 |
sfan5 |
writing a script to fetch them shouldn't be too hard |
| 19:11 |
Krock |
fetching.. so slow |
| 19:45 |
Krock |
updated #9015 but it really needs quality checking |
| 19:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/9015 -- [NO SQUASH] Translation update by SmallJoker |
| 19:45 |
Krock |
no idea why there are so many code movements. maybe gettext changed the way how they group translation entries |
| 19:46 |
Krock |
and it sometimes also contains comments. I could also try to only use the approved strings, but dunno whether they also contain comments |
| 19:49 |
|
ensonic joined #minetest-dev |
| 19:58 |
|
NoctisLabs joined #minetest-dev |
| 20:00 |
Krock |
found a way to trim it |
| 20:04 |
Krock |
fixed the PR. ready for review |
| 21:16 |
|
kilbith joined #minetest-dev |
| 21:20 |
|
paramat joined #minetest-dev |
| 21:27 |
|
kilbith_ joined #minetest-dev |
| 21:38 |
|
ssieb joined #minetest-dev |
| 22:43 |
|
Lone_Wolf joined #minetest-dev |
| 22:50 |
|
ANAND joined #minetest-dev |
| 23:22 |
|
Cornelia joined #minetest-dev |
| 23:42 |
|
GreenDimond joined #minetest-dev |
