| Time |
Nick |
Message |
| 00:06 |
|
YuGiOhJCJ joined #minetest-dev |
| 00:57 |
|
Lone_Wolf joined #minetest-dev |
| 01:25 |
|
paramat joined #minetest-dev |
| 01:26 |
|
Ruslan1 joined #minetest-dev |
| 01:53 |
|
Cornelia joined #minetest-dev |
| 03:06 |
|
Cornelia joined #minetest-dev |
| 03:18 |
|
Cornelia joined #minetest-dev |
| 04:14 |
|
Ruslan1 joined #minetest-dev |
| 04:19 |
|
AntumD joined #minetest-dev |
| 04:49 |
|
ensonic joined #minetest-dev |
| 05:17 |
|
fluxflux joined #minetest-dev |
| 05:30 |
|
fluxflux joined #minetest-dev |
| 05:45 |
|
nepugia joined #minetest-dev |
| 06:02 |
|
nolsen joined #minetest-dev |
| 08:38 |
|
ShadowNinja joined #minetest-dev |
| 09:44 |
|
Icedream- joined #minetest-dev |
| 09:49 |
|
Icedream joined #minetest-dev |
| 10:15 |
|
Wuzzy joined #minetest-dev |
| 10:38 |
|
proller joined #minetest-dev |
| 10:43 |
|
Fixer joined #minetest-dev |
| 13:46 |
|
troller joined #minetest-dev |
| 14:18 |
|
tomraceror joined #minetest-dev |
| 15:12 |
|
Krock joined #minetest-dev |
| 15:32 |
|
Foz joined #minetest-dev |
| 15:33 |
|
troller joined #minetest-dev |
| 15:38 |
|
HDMI_STECKDOSE joined #minetest-dev |
| 16:00 |
|
tomraceror joined #minetest-dev |
| 16:26 |
|
Ruslan1 joined #minetest-dev |
| 16:40 |
|
ensonic joined #minetest-dev |
| 17:06 |
|
Lone_Wolf joined #minetest-dev |
| 17:19 |
|
paramat joined #minetest-dev |
| 17:23 |
|
GreenDimond joined #minetest-dev |
| 17:25 |
|
Cornelia joined #minetest-dev |
| 17:39 |
Wuzzy |
Can I get an OK from core devs to rename the "Special" key (keymap_special1) to "Aux" consistently? |
| 17:39 |
Wuzzy |
I hate the "Aux" name personally, but its what the majority seems to want |
| 17:39 |
Wuzzy |
currently, minetest is using a mess of different names everywhere |
| 17:39 |
Wuzzy |
idea: |
| 17:40 |
Wuzzy |
player-facing name = "Aux". internal name = "aux1" |
| 17:40 |
Wuzzy |
why aux1? because its what most internal references already use |
| 17:40 |
Wuzzy |
so it would be less disruptive |
| 17:41 |
Krock |
OK |
| 17:41 |
Krock |
backwards compatibility would be great |
| 17:41 |
Wuzzy |
hmmm |
| 17:42 |
Wuzzy |
sooo i think the one internal identifier that is problematic is keymap_special1 |
| 17:42 |
Wuzzy |
the worst breakage we could cause is that the key config reverts to default for players |
| 17:43 |
Krock |
hence backwards compat |
| 17:43 |
Wuzzy |
having all identifiers being "aux1" except this one would be annoying |
| 17:43 |
Wuzzy |
sigh |
| 17:43 |
Krock |
it's three lines |
| 17:43 |
Wuzzy |
is this really that big of a deal? |
| 17:44 |
Wuzzy |
honestly i would want to have ONE unified name for this key. i want to clean up the mess, not add to it ? |
| 17:44 |
Krock |
try { key_name = g_settings->get("keymap_special1"); } catch (SettingNotFoundException &e) {} |
| 17:44 |
Krock |
note that SettingNotFoundException is only thrown when there's no defaults specified in defaultsettings.cpp |
| 17:45 |
Wuzzy |
well that block needs to be written each time keymap_special1 is invoked... kinda ugly |
| 17:45 |
Krock |
why? |
| 17:46 |
Krock |
keymaps are cached |
| 17:46 |
Wuzzy |
i see keymap_special1 multiple times in code |
| 17:47 |
Wuzzy |
Why is it so hard to just drop support for keymap_special1? |
| 17:47 |
Krock |
ah that |
| 17:47 |
Krock |
you just remove the setting in KeyCache::populate() if it was found, and replace it with keymap_aux1 |
| 17:47 |
Krock |
or anywhere else where the settings are read |
| 17:48 |
|
Cornelia joined #minetest-dev |
| 17:49 |
Wuzzy |
hrm. i better not touch this then... |
| 17:49 |
Krock |
actually ClientLauncher::init_input() is a better place to perform the setting replacement |
| 17:53 |
|
pauloue joined #minetest-dev |
| 17:58 |
Krock |
Wuzzy: https://krock-works.uk.to/u/patches/special1_backwards_compat.diff then replace all special1 references to aux1 |
| 17:58 |
Krock |
except in that code ofc |
| 18:07 |
|
fluxflux joined #minetest-dev |
| 18:38 |
paramat |
i prefer 'aux' everywhere, might as well do this right |
| 18:39 |
paramat |
and yes i support 'aux' |
| 18:41 |
paramat |
it is more important to sort out the mess than to have backwards compatibility, we can announce in the forum |
| 18:42 |
paramat |
being so intent on not breaking mods atall is partly the cause of mess in MT, occasionally i think it is better to break mods |
| 18:47 |
paramat |
" the worst breakage we could cause is that the key config reverts to default for players" that is acceptable and only a slight disruption, and far preferable to further mess |
| 18:50 |
paramat |
only takes a minute for a player to change their keybind. we really need to avoid unnecessary mess in MT |
| 18:57 |
sfan5 |
throwing away existing keysbinds isn't good, especially when backwards compatiblity can easily be included |
| 19:02 |
|
troller joined #minetest-dev |
| 19:07 |
|
vesper11 joined #minetest-dev |
| 19:08 |
|
proller joined #minetest-dev |
| 19:11 |
paramat |
yes, good intention but altering a keybind is quick and easy for a player. these kind of decisions add up to make the difference between clean and maintainable or not. but, whatever :) |
| 19:11 |
paramat |
i am not too bothered |
| 19:25 |
|
proller joined #minetest-dev |
| 19:27 |
|
troller joined #minetest-dev |
| 19:32 |
|
Cornelia joined #minetest-dev |
| 20:04 |
|
Fixer_ joined #minetest-dev |
| 20:04 |
|
pauloue joined #minetest-dev |
| 20:21 |
|
Cornelia joined #minetest-dev |
| 20:32 |
|
pauloue joined #minetest-dev |
| 20:48 |
|
Cornelia joined #minetest-dev |
| 20:49 |
|
Lone_Wolf joined #minetest-dev |
| 21:01 |
|
Taoki joined #minetest-dev |
| 21:17 |
|
Cornelia joined #minetest-dev |
| 21:22 |
|
troller joined #minetest-dev |
| 22:07 |
|
Cornelia joined #minetest-dev |
| 22:15 |
|
proller joined #minetest-dev |
| 22:20 |
|
Cornelia joined #minetest-dev |
| 22:23 |
|
paramat joined #minetest-dev |
| 22:37 |
Wuzzy |
thank you paramat |
| 22:50 |
|
Cornelia joined #minetest-dev |
| 22:57 |
|
Cornelia joined #minetest-dev |
| 23:09 |
paramat |
i would have merged it 3 hours earlier but i had to rush out somewhere =) |
| 23:09 |
paramat |
now, please can we actually do something about clang format? |
| 23:23 |
|
Cornelia joined #minetest-dev |
| 23:47 |
|
Cornelia joined #minetest-dev |
