| Time |
Nick |
Message |
| 00:04 |
|
kilbith joined #minetest-dev |
| 01:47 |
|
realz joined #minetest-dev |
| 02:36 |
|
NoctisLa1 joined #minetest-dev |
| 02:47 |
|
Ruslan1 joined #minetest-dev |
| 03:04 |
|
paramat joined #minetest-dev |
| 03:06 |
paramat |
merging #8928 , with thanks =) |
| 03:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/8928 -- Randomwalk caves: Add parameters for number and proportion flooded. Allow small randomwalk caves by paramat |
| 03:14 |
paramat |
next i will make it possible to completely disable the 3D noise tunnel generation, so that small randomwalk caves can be used instead if desired, this would disable calculation of 2 3D noises, so much less intensive |
| 03:17 |
paramat |
being on IRC makes me a little uncomfortable, sorry to be absent from here most of the time. however, i am happy to join if needed or for meetings, just post a message and i will see it in logs, which i keep an eye on |
| 03:18 |
paramat |
game#2535 |
| 03:18 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2535 -- Papyrus: Add to the rainforest swamp biome by paramat |
| 05:54 |
|
ssieb joined #minetest-dev |
| 07:24 |
|
pyrollo joined #minetest-dev |
| 08:38 |
|
ShadowNinja joined #minetest-dev |
| 09:18 |
|
proller joined #minetest-dev |
| 09:57 |
|
AntumDeluge joined #minetest-dev |
| 10:08 |
|
pyrollo joined #minetest-dev |
| 10:11 |
|
pyrollo joined #minetest-dev |
| 10:17 |
|
ensonic joined #minetest-dev |
| 10:47 |
|
proller joined #minetest-dev |
| 10:53 |
|
Fixer joined #minetest-dev |
| 11:19 |
|
kilbith joined #minetest-dev |
| 11:41 |
|
basxto joined #minetest-dev |
| 11:59 |
|
Fixer joined #minetest-dev |
| 12:05 |
|
proller joined #minetest-dev |
| 12:25 |
|
tomraceror joined #minetest-dev |
| 12:56 |
|
Icedream joined #minetest-dev |
| 13:02 |
|
proller joined #minetest-dev |
| 13:29 |
|
ensonic joined #minetest-dev |
| 13:30 |
|
ANAND joined #minetest-dev |
| 13:33 |
|
tomraceror joined #minetest-dev |
| 14:23 |
|
proller joined #minetest-dev |
| 15:05 |
|
tomraceror joined #minetest-dev |
| 15:18 |
|
Foz joined #minetest-dev |
| 15:33 |
IcyDiamond |
https://i.lunasqu.ee/Screenshot_19-11-08-17:32:55.png i've been scratching my head for a long time trying to figure out why this doesnt work, nothing gets added to the inventory even though the print there works |
| 15:34 |
IcyDiamond |
and the itemstack it prints is also correct |
| 15:34 |
IcyDiamond |
/giveme with it works |
| 15:36 |
IcyDiamond |
i have this code inside of a on_rightclick on a node btw |
| 15:37 |
IcyDiamond |
and right clicking this node with an item seems to make the add_item work |
| 15:37 |
IcyDiamond |
is this a bug? |
| 15:37 |
IcyDiamond |
it also works when i already have one of the item im trying to add in the inventory already |
| 15:38 |
sfan5 |
does the item appear if you log out and back in again? |
| 15:39 |
IcyDiamond |
nope |
| 15:39 |
IcyDiamond |
running the add_item in a minetest.after makes it work as well |
| 15:42 |
IcyDiamond |
https://gitlab.icynet.eu/evert/magicalities/blob/master/nodes.lua#L49 |
| 15:42 |
IcyDiamond |
here's the full source on that |
| 15:42 |
IcyDiamond |
that "-- idk" comment fixed it once too |
| 15:42 |
IcyDiamond |
in some magical way |
| 15:47 |
sfan5 |
does add_item return a leftover item stack? |
| 15:47 |
sfan5 |
have you tried reducing this to a smaller test case that reproduces the problem? |
| 15:48 |
IcyDiamond |
i'll have to try that |
| 15:51 |
IcyDiamond |
no it does not return any item stack |
| 15:55 |
IcyDiamond |
https://termbin.lunasqu.ee/tu3u minimal code where this is reproducable, at least in master branch |
| 15:55 |
sfan5 |
https://github.com/minetest/minetest/blob/master/src/script/lua_api/l_inventory.cpp#L293 |
| 15:55 |
sfan5 |
it should always return *something* even if it's an empty item stack |
| 15:56 |
IcyDiamond |
ah then it probably was empty, i just saw a blank line in log with the way i did it |
| 15:56 |
sfan5 |
are you sure the add_item actually runs? does it reproduce without the room_for_item? |
| 15:56 |
IcyDiamond |
if you add a print right before it, the print works |
| 15:57 |
IcyDiamond |
ok it doesnt work outside of the if either |
| 15:58 |
IcyDiamond |
https://termbin.lunasqu.ee/call new minimal |
| 15:58 |
IcyDiamond |
it prints "adding items (newline) nil" |
| 15:58 |
IcyDiamond |
but nothing is added |
| 15:59 |
IcyDiamond |
also doesnt work when right-clicking with the item im trying to give itself as well |
| 16:00 |
IcyDiamond |
let me try rebuilding my engine |
| 16:01 |
IcyDiamond |
nope, still happens |
| 16:02 |
IcyDiamond |
anything else i should try? |
| 16:03 |
IcyDiamond |
oh i get it |
| 16:03 |
IcyDiamond |
if you right click with the slot where the item would get added it doesnt work |
| 16:03 |
IcyDiamond |
nvm i dont get it |
| 16:21 |
rubenwardy |
IcyDiamond: what callback is it in? |
| 16:22 |
IcyDiamond |
on_rightclick |
| 16:22 |
rubenwardy |
Yeah, this is a bug |
| 16:22 |
rubenwardy |
Probably related to Krock's inventory changes |
| 16:26 |
rubenwardy |
Odd how logging out doesn't fix it if that were the cause |
| 16:29 |
|
Fixer joined #minetest-dev |
| 16:33 |
IcyDiamond |
formspec hypertext element came just in time for my magic mod guidebook |
| 16:39 |
|
Wuzzy joined #minetest-dev |
| 18:08 |
|
Krock joined #minetest-dev |
| 18:37 |
|
tomraceror joined #minetest-dev |
| 18:51 |
IcyDiamond |
https://gitlab.icynet.eu/evert/magicalities/blob/master/book.txt damn this is quite the mess |
| 18:51 |
IcyDiamond |
probably should've used json or something |
| 18:52 |
IcyDiamond |
xD |
| 18:53 |
IcyDiamond |
https://gitlab.icynet.eu/evert/magicalities/blob/master/mapgen.lua#L13 |
| 18:54 |
IcyDiamond |
i would like some input on this |
| 18:54 |
IcyDiamond |
it's a sparsely occuring structure |
| 18:56 |
IcyDiamond |
another note, i noticed a weird bug on the forum, apparently |
| 18:56 |
IcyDiamond |
i keep putting a link to my contentdb page but it gets shortened automatically and it breaks |
| 18:57 |
IcyDiamond |
https://content.minetest.net/packages/IcyDiamond/magicalities/ turns into https://content.minetest.net/packages/I ... icalities/ when i edit the post |
| 18:58 |
sfan5 |
known issue but we aren't really sure how to fix this |
| 18:58 |
IcyDiamond |
ok |
| 19:01 |
|
nornagon7 joined #minetest-dev |
| 19:05 |
|
tomraceror joined #minetest-dev |
| 19:14 |
p_gimeno |
maybe this fixes it? [url=https://content.minetest.net/packages/IcyDiamond/magicalities/] https://content.minetest.net/packages/IcyDiamond/magicalities/[/url] |
| 19:14 |
p_gimeno |
er, works around it |
| 19:17 |
|
ssieb joined #minetest-dev |
| 19:30 |
IcyDiamond |
Yeah I ended up just using [url] |
| 19:34 |
|
HDMI_STECKDOSE joined #minetest-dev |
| 19:49 |
|
paramat joined #minetest-dev |
| 19:49 |
paramat |
will merge trivial #9093 in 4 hours |
| 19:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/9093 -- Tunnels: Completely disable generation when 'cave width' >= 1000 by paramat |
| 20:04 |
|
kilbith joined #minetest-dev |
| 20:11 |
|
DI3HARD139 joined #minetest-dev |
| 20:38 |
IcyDiamond |
can anyone help me figure out good noise_params to use instead of fill_ratio = 0.00000001 on a rare decoration? |
| 20:39 |
Krock |
fill_ratio = 1E-8 |
| 20:39 |
IcyDiamond |
lmao |
| 20:39 |
Krock |
or maybe scale the noise down a bit |
| 20:39 |
Krock |
i.e. scale < 1 |
| 20:50 |
|
Fixer joined #minetest-dev |
| 20:53 |
|
paramat joined #minetest-dev |
| 20:58 |
paramat |
hmm ... |
| 20:59 |
IcyDiamond |
https://i.lunasqu.ee/Screenshot_19-11-08-22:58:44.png nice pond |
| 20:59 |
IcyDiamond |
minetest mapgen is gorgeous btw |
| 21:00 |
paramat |
offset = 0.00000001, scale = 0.00000001 will be roughly equivalent |
| 21:01 |
paramat |
wow nice pool, lucky find |
| 21:02 |
Krock |
wow nice. that's a perfect fit |
| 21:03 |
|
HDMI_STECKDOSE joined #minetest-dev |
| 21:04 |
paramat |
however, a decoration that rare will not make variation by noise noticeable, so it is best just to use fill_ratio = 0.00000001 |
| 21:04 |
paramat |
well, unless you use a very large noise 'spread' |
| 21:05 |
paramat |
so it is only worth doing if noise spread is much larger than the average distance between decorations |
| 21:06 |
paramat |
but, this is offtopic, you can pm me if you want |
| 21:07 |
Krock |
will merge #7926 in 10 minutes. Does not break anything, and is a bugfix only |
| 21:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/7926 -- Make core.get_favorites("local") ignore duplicates by pauloue |
| 21:16 |
paramat |
ok |
| 21:17 |
Krock |
paramat: for #9093: wouldn't 10.0 already suffice? |
| 21:17 |
ShadowBot |
https://github.com/minetest/minetest/issues/9093 -- Tunnels: Completely disable generation when 'cave width' >= 1000 by paramat |
| 21:17 |
Krock |
because that's already used as magic limit for decorations |
| 21:17 |
Krock |
merging.. |
| 21:44 |
sfan5 |
radius = std::max<int>(radius, getClient(L)->getCSMNodeRangeLimit()); |
| 21:44 |
sfan5 |
quiz: what is wrong here? |
| 21:47 |
paramat |
!tell Krock i chose 1000 because if noise params are customised, the value of 'cave width' that causes zero width tunnels could be much higher than 1. so it seemed 1000 gave a suitable safety margin |
| 21:47 |
ShadowBot |
paramat: O.K. |
| 21:49 |
paramat |
hm, erm, radius can be set larger than the limit? |
| 21:49 |
sfan5 |
yeah that's it |
| 21:50 |
paramat |
lol |
| 21:58 |
paramat |
or rather, cannot be lower than the limit |
| 22:00 |
sfan5 |
the whole thing is ineffective anyway since you can choose the position the search starts at, even if the limit was correctly enforced to e.g. 1 you could look everywhere you wanted |
| 22:04 |
Calinou |
probably has been asked before, but does Minetest use https://www.sqlite.org/wal.html ? If not, would it make sense to use it? |
| 22:08 |
|
rubenwardy left #minetest-dev |
| 22:08 |
|
rubenwardy joined #minetest-dev |
| 22:10 |
p_gimeno |
I've wondered the same. I looked, but I didn't see any WAL file at runtime. |
| 22:26 |
paramat |
"you can choose the position the search starts at" aahh ... well spotted |
| 22:30 |
paramat |
maybe we could remove the range csm restriction then, just allow or disallow |
| 22:32 |
sfan5 |
that's not a bad idea |
| 22:33 |
paramat |
Krock, perhaps 10 is better actually, i will change it. a factor of 10 safety margin is reasonable |
| 22:56 |
paramat |
#9094 simple and very effective for rw caves |
| 22:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/9094 -- Randomwalk caves: Extend beyond mapchunk vertically also by paramat |
| 23:13 |
paramat |
#9093 updated as requested, will merge in 1 hour |
| 23:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/9093 -- Tunnels: Completely disable generation when 'cave width' >= 10 by paramat |
| 23:36 |
|
Ruslan1 joined #minetest-dev |
