| Time |
Nick |
Message |
| 00:23 |
|
ANAND joined #minetest-dev |
| 00:25 |
|
realz joined #minetest-dev |
| 00:25 |
|
Cornelia joined #minetest-dev |
| 00:33 |
|
Cornelia joined #minetest-dev |
| 00:42 |
|
Cornelia joined #minetest-dev |
| 00:47 |
ANAND |
~tell Krock I see. Thanks for letting me know. If only a solution is that simple... :P |
| 00:47 |
ShadowBot |
ANAND: O.K. |
| 01:01 |
|
minetesting joined #minetest-dev |
| 01:10 |
|
Kimapr joined #minetest-dev |
| 01:41 |
|
erlehmann joined #minetest-dev |
| 01:53 |
|
NoctisLabs joined #minetest-dev |
| 02:20 |
|
nephele joined #minetest-dev |
| 03:04 |
|
YuGiOhJCJ joined #minetest-dev |
| 03:05 |
|
fluxflux joined #minetest-dev |
| 03:31 |
|
Icedream joined #minetest-dev |
| 04:20 |
|
erlehmann joined #minetest-dev |
| 06:41 |
|
Ruslan1 joined #minetest-dev |
| 06:43 |
|
fluxflux_ joined #minetest-dev |
| 07:16 |
|
nephele joined #minetest-dev |
| 07:59 |
|
erlehmann joined #minetest-dev |
| 08:17 |
|
erlehmann joined #minetest-dev |
| 08:32 |
|
Krock joined #minetest-dev |
| 08:39 |
|
ShadowNinja joined #minetest-dev |
| 09:21 |
|
HDMI_STECKDOSE joined #minetest-dev |
| 09:34 |
|
tomraceror joined #minetest-dev |
| 11:17 |
|
nepugia joined #minetest-dev |
| 11:19 |
|
Fixer joined #minetest-dev |
| 11:47 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:49 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:51 |
Krock |
#9177 |
| 11:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/9177 -- Add core.get_player_or_load by SmallJoker |
| 12:23 |
rubenwardy |
I suggest forbidding the player refs from being stored, meaning they could be invalidated between callbacks. This way mods don't need to care about when a player is loaded, it's handled by the engine |
| 12:24 |
Krock |
you may not store ObjectRefs anyway |
| 12:24 |
Krock |
s/store/keep them referenced after leaving a callback/ |
| 12:25 |
rubenwardy |
Yeah |
| 12:26 |
rubenwardy |
Therefore it's fine for the engine to unload players outside of callbacks |
| 12:26 |
rubenwardy |
Players may only join when packets are being received, which is outside of callbacks |
| 12:29 |
Krock |
hmm.. hooking runCallbacks() |
| 12:29 |
Krock |
tbh I'm not very happy about this approach |
| 12:30 |
Krock |
what if the player is modified on mod load? |
| 12:42 |
rubenwardy |
No need to hook run callbacks |
| 12:43 |
rubenwardy |
I haven't looked at the pr yet |
| 12:43 |
rubenwardy |
But defining using a playerred between callbacks as undefined behaviour |
| 12:44 |
rubenwardy |
And then forcefully closing references between a player joins is fine to me |
| 12:48 |
|
ensonic joined #minetest-dev |
| 14:17 |
|
H4mlet joined #minetest-dev |
| 14:19 |
|
fluxflux joined #minetest-dev |
| 14:35 |
|
Taoki joined #minetest-dev |
| 14:41 |
|
Taoki joined #minetest-dev |
| 15:57 |
|
BrunoMine joined #minetest-dev |
| 16:01 |
|
BrunoMine left #minetest-dev |
| 16:07 |
|
BrunoMine joined #minetest-dev |
| 17:11 |
|
Ruslan1 joined #minetest-dev |
| 17:22 |
|
H4mlet joined #minetest-dev |
| 17:52 |
sfan5 |
merging #8996 in 5 minutes |
| 17:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/8996 -- Formspec: make bgcolor element less confusing and allow setting fullscreen color by DS-Minetest |
| 18:05 |
|
erlehmann joined #minetest-dev |
| 19:14 |
|
ensonic joined #minetest-dev |
| 19:19 |
|
Ruslan1 joined #minetest-dev |
| 20:09 |
|
H4mlet joined #minetest-dev |
| 21:38 |
|
NoctisLabs joined #minetest-dev |
| 22:22 |
Fixer |
this may be a serious bug linked to outdated translation not letting players to connect to servers: https://github.com/minetest/minetest/issues/8568 |
| 22:23 |
|
Taoki joined #minetest-dev |
| 22:27 |
|
erlehmann_ joined #minetest-dev |
| 23:53 |
|
erlehmann joined #minetest-dev |
