| Time |
Nick |
Message |
| 00:20 |
|
Taoki joined #minetest-dev |
| 00:21 |
oil_boi |
I am so sick of the CSM not loading after joining a remote server (https://github.com/minetest/minetest/issues/10024) I made a very boring video of it happening: https://youtu.be/0v_q1f6cEnc Krock |
| 00:22 |
oil_boi |
!title |
| 00:22 |
ShadowBot |
oil_boi: Error: That URL appears to have no HTML title within the first 4KB. |
| 01:11 |
|
ANAND joined #minetest-dev |
| 04:06 |
|
gh00p joined #minetest-dev |
| 04:12 |
|
ghoti joined #minetest-dev |
| 04:24 |
|
Miner_48er joined #minetest-dev |
| 05:05 |
|
ANAND joined #minetest-dev |
| 05:59 |
|
absurb joined #minetest-dev |
| 06:09 |
|
calcul0n joined #minetest-dev |
| 07:43 |
|
NetherEran joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 08:01 |
Krock |
!tell Zughy Milestones in Minetest are for important bugfixes that must be merged or solved in other ways for the next release. I know well that it's not motivating like this, but what can we do? |
| 08:01 |
ShadowBot |
Krock: O.K. |
| 08:18 |
|
NetherEran_ joined #minetest-dev |
| 08:42 |
|
Fixer joined #minetest-dev |
| 09:56 |
|
shadowmaker joined #minetest-dev |
| 09:57 |
|
shadowmaker left #minetest-dev |
| 11:13 |
|
oil_boi joined #minetest-dev |
| 12:31 |
|
erlehmann joined #minetest-dev |
| 12:48 |
|
olliy joined #minetest-dev |
| 12:56 |
|
olliy_ joined #minetest-dev |
| 12:57 |
|
Taoki joined #minetest-dev |
| 12:59 |
|
YuGiOhJCJ joined #minetest-dev |
| 13:13 |
PGimeno |
PR up for adoption: https://notabug.org/pgimeno/minetest/pulls/6 |
| 13:16 |
sfan5 |
around like ~192, if sin and cos already exist why not move that definition up instead of adding math_sin and math_cos |
| 13:16 |
sfan5 |
line* |
| 13:21 |
NetherEran_ |
PGimeno: your implementation of vector.dir_to_rotation breaks when `forward` isn't a unit vector. |
| 13:22 |
PGimeno |
NetherEran_: example please? |
| 13:22 |
NetherEran_ |
run the unit tests |
| 13:23 |
NetherEran_ |
math.asin(forward.y) to calculate pitch depends on it being a unit vector |
| 13:23 |
PGimeno |
sfan5: sin and cos use math_sin and math_cos |
| 13:24 |
PGimeno |
oh good point |
| 13:24 |
sfan5 |
oh it's those weird wrappers |
| 13:24 |
sfan5 |
the naming certainly is confusing |
| 13:24 |
sfan5 |
well maybe not |
| 13:24 |
PGimeno |
sfan5: they exist to ensure that sin(pi)=0 for example, instead of ~1E-16 |
| 13:30 |
PGimeno |
NetherEran_: thanks, fixed |
| 13:33 |
PGimeno |
ideally, the functions vector.xxxxx should also be cached |
| 13:38 |
PGimeno |
how do I run the Lua unit tests? |
| 13:39 |
PGimeno |
I've tried with bin/minetest --run-unittests but they don't appear to run |
| 13:39 |
NetherEran_ |
$ busted builtin |
| 13:39 |
NetherEran_ |
in the minetest directory |
| 13:40 |
PGimeno |
hm, that should be documented somewhere, as well as the dependency on busted |
| 13:41 |
NetherEran_ |
true |
| 13:42 |
|
Fixer joined #minetest-dev |
| 13:42 |
PGimeno |
I expected minetest --run-unittests to run all tests including Lua tests |
| 13:43 |
sfan5 |
running unittests in the minetests lua environment would be a good thing to do eventually |
| 13:53 |
PGimeno |
busted doesn't seem to be running during builds |
| 14:01 |
sfan5 |
https://github.com/minetest/minetest/runs/754896261 |
| 14:04 |
|
EvergreenTree joined #minetest-dev |
| 14:23 |
PGimeno |
thanks, I can't make much sense from that but now I see I was wrong, https://github.com/minetest/minetest/blob/master/.github/workflows/lua_lint.yml#L32 |
| 14:44 |
|
NetherEran joined #minetest-dev |
| 14:48 |
Krock |
Is a meeting needed today? |
| 14:48 |
Krock |
would basically be about feature freeze and PR/issue discussion |
| 14:49 |
Krock |
of what's left in the milestone |
| 14:55 |
|
absurb joined #minetest-dev |
| 14:58 |
sfan5 |
does the freeze start after the meeting? |
| 14:59 |
sfan5 |
since #9961 (feature PR) has enough approvals and I'd like to merge it unless there are concerns |
| 14:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/9961 -- Server pushing media at runtime by sfan5 |
| 15:07 |
Krock |
can still be merged today |
| 15:08 |
Krock |
though I think it'll become an overused API as soon modders get used to it. No media unloading makes it look like a memory leak |
| 15:09 |
Krock |
not a problem to solve for this PR. |
| 15:15 |
sfan5 |
agree |
| 15:16 |
Krock |
... changelog is due again. I'll do that |
| 16:36 |
|
NetherEran joined #minetest-dev |
| 16:40 |
|
Jordach joined #minetest-dev |
| 16:50 |
sfan5 |
merging #9961 in 10 minutes |
| 16:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/9961 -- Server pushing media at runtime by sfan5 |
| 17:05 |
Krock |
ping |
| 17:05 |
sfan5 |
pong |
| 17:06 |
Krock |
1 packets transmitted, 1 received, 0% packet loss, time 3000ms |
| 18:43 |
|
reductum joined #minetest-dev |
| 18:51 |
|
YuGiOhJCJ joined #minetest-dev |
| 19:21 |
|
reductum joined #minetest-dev |
| 19:31 |
|
Fixer joined #minetest-dev |
| 19:52 |
Krock |
Changelog updated for minetest/minetest |
| 19:55 |
Krock |
Updating channel title in a few minutes if there are no objections |
| 19:56 |
Krock |
Only #9903 is left over as a feature PR, which does not seem too important |
| 19:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/9903 -- Properly implement exposing the zoom key by appgurueu |
| 20:06 |
sfan5 |
would be very simple to put into 5.3 though |
| 20:09 |
|
behalebabo joined #minetest-dev |
| 20:11 |
Krock |
whatever. I'll merge it in 10 minutes and update the topic afterwards |
| 20:35 |
|
Fixer joined #minetest-dev |
| 20:45 |
Krock |
10 minutes are over |
| 20:47 |
|
Topic for #minetest-dev is now Minetest core development and maintenance. 5.3.0-dev FEATURE FREEZE in effect! Chit-chat goes to #minetest. http://irc.minetest.net/minetest-dev/ http://dev.minetest.net/ |
| 20:47 |
Krock |
Feature freeze has begun. Bugfix time :) |
| 20:51 |
sfan5 |
:+1: |
| 20:52 |
sfan5 |
wait that means the translation stuff should be updated too |
| 20:52 |
sfan5 |
if only Wuzzy was here so I could ask him about the script to do it for MTG |
| 20:52 |
Krock |
yes |
| 20:53 |
Krock |
https://notabug.org/pgimeno/minetest/src/translation-toolchain/util/updatetext.lua |
| 20:56 |
sfan5 |
thx |
| 20:56 |
sfan5 |
i'll do it for MT first in like 5 minutes |
| 20:59 |
PGimeno |
it's weird that you're using my repo for that script, the only thing I changed in that branch was findtext.lua |
| 21:00 |
PGimeno |
but if the glove fits... :) |
| 21:00 |
|
reductum joined #minetest-dev |
| 21:05 |
PGimeno |
https://github.com/Ekdohibs/minetest/commits/translation-toolchain is the branch I used as a basis |
| 21:06 |
PGimeno |
(letting you know just in case notabug is down at some point, so you don't depend on it) |
| 21:30 |
sfan5 |
translations are done for the engine but weblate is being very slow |
| 21:46 |
sfan5 |
>lua findtext.lua -o mods/default/locale/template.txt $(find mods/default/ -name '*.lua') |
| 21:46 |
sfan5 |
results in an empty template |
| 21:53 |
PGimeno |
where do you run that? |
| 21:54 |
sfan5 |
does the cwd matter? |
| 21:54 |
PGimeno |
I'm trying to replicate what you're doing |
| 21:55 |
sfan5 |
in games/minetest_game/ |
| 21:59 |
|
erlehmann joined #minetest-dev |
| 22:02 |
PGimeno |
it doesn't seem to be designed to work with the files like that, it would need some changes |
| 22:03 |
sfan5 |
would concatenating all default files work? |
| 22:03 |
PGimeno |
it expects to find in each file a line like: local S = minetest.get_translator("domain") |
| 22:05 |
PGimeno |
concatenating a header file containing a line like that, with all other files, should work |
| 22:05 |
PGimeno |
something like: echo 'local S = minetest.get_translator("domain")' | cat - $(find mods/default/ -name '*.lua') > alltext.lua |
| 22:08 |
PGimeno |
it should probably be made compatible with what we have, e.g. looking for init.lua first |
| 22:11 |
|
fluxflux joined #minetest-dev |
| 22:11 |
sfan5 |
templates don't seem to be sorted so updating them causes lots of unnecessary changes |
| 22:12 |
sfan5 |
or maybe sorted differently from when they were initially generated... |
| 22:12 |
PGimeno |
they are sorted alphabetically AFAIK |
| 22:13 |
PGimeno |
note I didn't write the program, I didn't even know what it should do, all I did was improve the parsing because there were issues recognizing strings |
| 22:13 |
sfan5 |
hm yep looks sorted |
| 22:13 |
sfan5 |
wonder why the previous templates weren't sorted them |
| 22:13 |
sfan5 |
then* |
| 22:14 |
PGimeno |
I don't think they were processed by that script, no idea how they were though |
| 22:14 |
|
Wuzzy joined #minetest-dev |
| 22:14 |
PGimeno |
ooh just in time! |
| 22:15 |
sfan5 |
updatetext.lua doesn't seem to respect the -o option at all |
| 22:16 |
PGimeno |
heh indeed |
| 22:16 |
PGimeno |
eh wait, it should |
| 22:16 |
sfan5 |
but it also updates the catalog in place |
| 22:17 |
sfan5 |
then what is the point of -o? |
| 22:17 |
|
pauloue joined #minetest-dev |
| 22:18 |
PGimeno |
no idea, sorry |
| 22:19 |
PGimeno |
<sfan5> if only Wuzzy was here so I could ask him about the script to do it [update translations] for MTG |
| 22:19 |
sfan5 |
I think I almost have it figured out |
| 22:20 |
Wuzzy |
oh hi ? |
| 22:21 |
Wuzzy |
ohhhhhhhhhhhh it's feature freeze! |
| 22:21 |
Wuzzy |
okay about the update script... to be honest, we dont have anything official yet ? |
| 22:21 |
Wuzzy |
But I remember seeing some unofficial script. but it kinda sucks |
| 22:21 |
sfan5 |
I don't care about official, it just needs to work |
| 22:22 |
Wuzzy |
? |
| 22:22 |
sfan5 |
lua: /tmp/minetest_game/updatetext.lua:136: attempt to index a nil value (field '?') |
| 22:22 |
sfan5 |
:c |
| 22:23 |
Wuzzy |
https://raw.githubusercontent.com/Ganome/OPSkyBlock/8381cbb8befb6e73e40c9f8ae9de2b6527d22a4f/mods/intllib/tools/updatetext.lua |
| 22:23 |
Wuzzy |
I make no promises that this script works |
| 22:23 |
pauloue |
I used https://github.com/minetest-tools/update_translations and it worked well |
| 22:23 |
Wuzzy |
ohhh |
| 22:23 |
Wuzzy |
this might be better |
| 22:24 |
Wuzzy |
python |
| 22:26 |
PGimeno |
yeah, that's a language better suited for the task |
| 22:27 |
Wuzzy |
ugh, but this script still kinda sucks. it creates invalid files |
| 22:27 |
Wuzzy |
it seems it just appends the output to the existing translations, including the "# textdomain" |
| 22:38 |
sfan5 |
https://github.com/minetest/minetest_game/blob/translation_update/updatepo.sh this is what I have so far |
| 22:38 |
sfan5 |
and the changes it creates -> https://github.com/minetest/minetest_game/commit/5180925c331deb96db358ff2714eb32750fcf467 |
| 22:43 |
Wuzzy |
is not very well formatted |
| 22:43 |
Wuzzy |
output is ugly, still needs manual repair apparently |
| 22:45 |
sfan5 |
findtext is doing fine |
| 22:45 |
PGimeno |
sfan5: can't you just sed '/^# textdomain:/d' ? |
| 22:45 |
sfan5 |
except for maybe the "Outer " translation which I'm sure does not exist |
| 22:45 |
sfan5 |
updatetext should comment old lines and add commented new lines in instead of that appending thing |
| 22:45 |
sfan5 |
PGimeno: would delete the first textdomain too |
| 22:47 |
PGimeno |
https://unix.stackexchange.com/questions/257819/remove-extra-header-lines-from-file-except-for-the-first-line/257820#257820 |
| 22:48 |
sfan5 |
..sed syntax really is worse than perl |
| 22:49 |
PGimeno |
heheh |
| 22:49 |
PGimeno |
I think this might work too: sed '1n;/^# textdomain:/d' |
| 22:49 |
Wuzzy |
the python script is pretty good tho, but it needs tweaking |
| 22:50 |
sfan5 |
anyway i'm going to bed |
| 22:50 |
PGimeno |
python is definitely a much better tool for this; I had to work around the lack of regular expressions with state machines |
| 23:53 |
oil_boi |
Krock, I'll make a video for you with the diff changes so you can see the live output |
| 23:57 |
oil_boi |
wait no |
| 23:57 |
oil_boi |
I can just show you |
| 23:59 |
oil_boi |
Krock, https://pastebin.com/raw/eQG2GLWG |
