| Time |
Nick |
Message |
| 00:07 |
|
Eman108 joined #minetest-dev |
| 00:52 |
|
tsadok joined #minetest-dev |
| 01:11 |
|
Taoki joined #minetest-dev |
| 01:28 |
|
Taoki joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 06:32 |
|
proller joined #minetest-dev |
| 06:36 |
|
troller joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 09:10 |
|
MTDiscord joined #minetest-dev |
| 09:14 |
|
calcul0n joined #minetest-dev |
| 09:16 |
|
MTDiscord1 joined #minetest-dev |
| 09:19 |
|
MTDiscord joined #minetest-dev |
| 09:24 |
sfan5 |
merging game#2862 in 5m |
| 09:24 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2862 -- Check for attachments before attaching player to bed by ElCeejo |
| 09:34 |
|
entuland joined #minetest-dev |
| 10:10 |
|
hlqkj joined #minetest-dev |
| 10:44 |
|
calcul0n_ joined #minetest-dev |
| 11:41 |
|
Fixer joined #minetest-dev |
| 11:52 |
|
entuland joined #minetest-dev |
| 12:08 |
|
tech_exorcist joined #minetest-dev |
| 12:35 |
sfan5 |
merging game#2863, game#2851 in 7m |
| 12:36 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2863 -- Use group for mushroom spread ABM by tenplus1 |
| 12:36 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2851 -- Reclassify some items by An0n3m0us |
| 14:18 |
|
hlqkj joined #minetest-dev |
| 15:51 |
|
Fixer_ joined #minetest-dev |
| 15:56 |
|
absurb joined #minetest-dev |
| 16:15 |
|
Fixer joined #minetest-dev |
| 16:26 |
|
ircSparky joined #minetest-dev |
| 16:26 |
|
ircSparky joined #minetest-dev |
| 17:02 |
nerzhul |
sfan5: i'm working on some tidy on the cmake part |
| 17:05 |
nerzhul |
i will propose a PR to move gui folder to the client folder as it's pure client side :) |
| 17:10 |
sfan5 |
I don't think folders should be nested too much |
| 17:10 |
nerzhul |
it's just a single move |
| 17:10 |
nerzhul |
after that we may flatten in another PR is you prefer |
| 17:11 |
sfan5 |
moving all gui files directly to src/client wouldn't be useful either |
| 17:12 |
nerzhul |
it ensure we won't use them on other code parts, GUI is not a server part, i think src/ root must contain only common stuff and client specific should be in src/client |
| 17:12 |
nerzhul |
#11253 is ready for a review :) |
| 17:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/11253 -- CMake/Gui: organizational changes by nerzhul |
| 17:13 |
sfan5 |
looking forward to src/client/script/lua_api/ then |
| 17:13 |
nerzhul |
the lua_api should be moved at a point maybe too yep |
| 17:13 |
nerzhul |
namespace all on the client folder can be a nice target i think |
| 17:15 |
sfan5 |
that was sarcasm, having to navigate 4 folders to find a single file is not useful |
| 17:17 |
nerzhul |
you don't use an IDE and just do CTRL+click ? :D |
| 17:18 |
sfan5 |
I use vscode, ctrl+click doesn't seem to do anything. I assume it expands the entire folder tree? |
| 17:18 |
nerzhul |
i use vscode and it works |
| 17:18 |
nerzhul |
did you installed cmake, cmake tools & c/c++ extensions ? |
| 17:18 |
nerzhul |
if you setup that properly no code folding issues |
| 17:19 |
nerzhul |
i just have git integration broken on the latest version anyway git is simple |
| 17:21 |
nerzhul |
for the lua_api, thinking about your idea, regarding how it's done i don't think we cannot do it easily, not in the current state, and it's pretty fine in that case currently. For gui it's more a code clarification, to move all client things on client, like all others we have :) |
| 17:21 |
nerzhul |
no other client specific folder has been missed in client except this one currently |
| 17:22 |
sfan5 |
irrlicht_changes? |
| 17:23 |
nerzhul |
ah yeah right this one is a candidate :) |
| 17:23 |
nerzhul |
i can add it this this PR, it should take 5 mins |
| 17:24 |
nerzhul |
all includes to that folder are already in src/client (if we include the gui moved one) |
| 17:27 |
nerzhul |
PR is amended :) |
| 17:37 |
sfan5 |
pushing http://sprunge.us/9qE0oQ?diff in a few mins |
| 17:37 |
nerzhul |
what is that fix ? |
| 17:39 |
sfan5 |
the inventory overlay wasn't drawn when it should be |
| 17:41 |
nerzhul |
okay |
| 17:42 |
sfan5 |
hm wait I think the fix is still wrong |
| 17:46 |
sfan5 |
new patch http://sprunge.us/tMIbHH?diff |
| 17:48 |
|
silver_est joined #minetest-dev |
| 17:48 |
pgimeno |
maybe worth a PR? |
| 17:50 |
sfan5 |
it's correct this time :) |
| 18:23 |
nerzhul |
cool :) |
| 18:24 |
nerzhul |
i hope we can move forward on my PR, following that i just found some enhancements to reduce a bit client exposure in code, i continue my investigations |
| 18:36 |
nerzhul |
sfan5, did you changed something in build system ? mingw fail to find al.h |
| 18:38 |
sfan5 |
it works in master so can't be me |
| 18:38 |
|
appguru joined #minetest-dev |
| 19:05 |
|
hlqkj joined #minetest-dev |
| 20:56 |
|
Fleckenstein joined #minetest-dev |
