| Time |
Nick |
Message |
| 01:00 |
|
YuGiOhJCJ joined #minetest-dev |
| 02:33 |
|
YuGiOhJCJ joined #minetest-dev |
| 02:35 |
|
Noisytoot joined #minetest-dev |
| 02:41 |
|
v-rob joined #minetest-dev |
| 03:24 |
|
diceLibrarian joined #minetest-dev |
| 03:55 |
|
v-rob joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 05:01 |
|
MTDiscord joined #minetest-dev |
| 05:03 |
|
diceLibrarian joined #minetest-dev |
| 05:03 |
|
panwolfram joined #minetest-dev |
| 05:03 |
|
hmmmm joined #minetest-dev |
| 05:03 |
|
cheapie joined #minetest-dev |
| 05:03 |
|
[0] joined #minetest-dev |
| 05:03 |
|
book`_ joined #minetest-dev |
| 05:03 |
|
Thomas-S joined #minetest-dev |
| 05:03 |
|
sofar joined #minetest-dev |
| 05:03 |
|
dzho joined #minetest-dev |
| 05:03 |
|
MTDiscord1 joined #minetest-dev |
| 05:05 |
|
calcul0n joined #minetest-dev |
| 05:05 |
|
v-rob joined #minetest-dev |
| 05:06 |
|
YuGiOhJCJ joined #minetest-dev |
| 05:06 |
|
YuGiOhJCJ joined #minetest-dev |
| 05:07 |
|
nrz joined #minetest-dev |
| 05:07 |
|
izzyb joined #minetest-dev |
| 05:07 |
|
Soni joined #minetest-dev |
| 05:07 |
|
Evergreen joined #minetest-dev |
| 05:07 |
|
ivanbu joined #minetest-dev |
| 05:07 |
|
Calinou joined #minetest-dev |
| 05:07 |
|
bigfoot547 joined #minetest-dev |
| 05:07 |
|
ShadowBot joined #minetest-dev |
| 05:07 |
|
nrz joined #minetest-dev |
| 05:08 |
|
Noisytoot joined #minetest-dev |
| 05:10 |
|
Noisytoot joined #minetest-dev |
| 05:10 |
|
nrz joined #minetest-dev |
| 05:10 |
|
ShadowBot joined #minetest-dev |
| 05:10 |
|
bigfoot547 joined #minetest-dev |
| 05:10 |
|
Calinou joined #minetest-dev |
| 05:10 |
|
ivanbu joined #minetest-dev |
| 05:10 |
|
Evergreen joined #minetest-dev |
| 05:10 |
|
Soni joined #minetest-dev |
| 05:10 |
|
izzyb joined #minetest-dev |
| 05:10 |
|
YuGiOhJCJ joined #minetest-dev |
| 05:10 |
|
v-rob joined #minetest-dev |
| 05:10 |
|
MTDiscord joined #minetest-dev |
| 05:10 |
|
dzho joined #minetest-dev |
| 05:10 |
|
sofar joined #minetest-dev |
| 05:10 |
|
Thomas-S joined #minetest-dev |
| 05:10 |
|
book`_ joined #minetest-dev |
| 05:10 |
|
[0] joined #minetest-dev |
| 05:10 |
|
cheapie joined #minetest-dev |
| 05:10 |
|
hmmmm joined #minetest-dev |
| 05:10 |
|
panwolfram joined #minetest-dev |
| 05:10 |
|
diceLibrarian joined #minetest-dev |
| 05:10 |
|
sfan5 joined #minetest-dev |
| 05:10 |
|
MrDraxs[m] joined #minetest-dev |
| 05:10 |
|
Sokomine joined #minetest-dev |
| 05:10 |
|
paradust_ joined #minetest-dev |
| 05:10 |
|
Taoki joined #minetest-dev |
| 05:10 |
|
clavi joined #minetest-dev |
| 05:10 |
|
AliasAlreadyTake joined #minetest-dev |
| 05:10 |
|
AliasAlreadyTake joined #minetest-dev |
| 05:11 |
|
MrDraxs[m] joined #minetest-dev |
| 05:11 |
|
sfan5 joined #minetest-dev |
| 05:11 |
|
calcul0n joined #minetest-dev |
| 05:11 |
|
lebruhgamer[m] joined #minetest-dev |
| 05:12 |
|
fossdev2 joined #minetest-dev |
| 05:12 |
|
Warr1024 joined #minetest-dev |
| 05:12 |
|
basxto joined #minetest-dev |
| 05:12 |
|
Goobax[m]1 joined #minetest-dev |
| 05:12 |
|
Zughy[m] joined #minetest-dev |
| 05:12 |
|
m42uko joined #minetest-dev |
| 05:12 |
|
rubenwardy joined #minetest-dev |
| 05:12 |
|
nore joined #minetest-dev |
| 05:13 |
|
TheCoffeMaker joined #minetest-dev |
| 05:13 |
|
fluxionary joined #minetest-dev |
| 05:13 |
|
behalebabo joined #minetest-dev |
| 05:13 |
|
Pexin joined #minetest-dev |
| 05:13 |
|
beanzilla joined #minetest-dev |
| 05:13 |
|
luk3yx joined #minetest-dev |
| 05:13 |
|
celeron55 joined #minetest-dev |
| 05:13 |
|
wsor joined #minetest-dev |
| 05:13 |
|
jonadab joined #minetest-dev |
| 05:13 |
|
BuckarooBanzai joined #minetest-dev |
| 05:14 |
|
nrz joined #minetest-dev |
| 05:14 |
|
clavi joined #minetest-dev |
| 05:14 |
|
Taoki joined #minetest-dev |
| 05:14 |
|
paradust_ joined #minetest-dev |
| 05:14 |
|
Sokomine joined #minetest-dev |
| 05:14 |
|
TheCoffeMaker joined #minetest-dev |
| 05:15 |
|
nrz joined #minetest-dev |
| 05:34 |
|
programmerjake joined #minetest-dev |
| 05:36 |
|
lebruhgamer[m] joined #minetest-dev |
| 05:45 |
|
MisterE[m] joined #minetest-dev |
| 06:19 |
|
freshreplicant[m joined #minetest-dev |
| 06:44 |
|
Zughy[m] joined #minetest-dev |
| 07:10 |
|
schwarzwald[m] joined #minetest-dev |
| 07:16 |
|
Warr10244 joined #minetest-dev |
| 07:20 |
|
Goobax[m]1 joined #minetest-dev |
| 07:20 |
|
appguru joined #minetest-dev |
| 07:23 |
|
MrDraxs[m] joined #minetest-dev |
| 07:28 |
|
v-rob joined #minetest-dev |
| 08:17 |
|
MTDiscord2 joined #minetest-dev |
| 08:22 |
|
Warr1024 joined #minetest-dev |
| 09:04 |
|
Warr1024 joined #minetest-dev |
| 09:28 |
|
Fixer joined #minetest-dev |
| 10:51 |
|
olliy joined #minetest-dev |
| 12:11 |
|
HuguesRoss joined #minetest-dev |
| 12:13 |
|
proller joined #minetest-dev |
| 12:34 |
|
appguru joined #minetest-dev |
| 13:38 |
|
appguru joined #minetest-dev |
| 13:50 |
MTDiscord |
<x2048> Pushing a small patch in a few minutes https://pastebin.com/VfAqeB1Y. Fixes #12686 |
| 13:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/12686 -- 5.6 changed object glow drastically |
| 14:04 |
sfan5 |
I looked at that issue before and wondered if that was the right fix since the glow stuff changed so drastically |
| 14:04 |
sfan5 |
thanks for fixing |
| 14:32 |
|
kilbith joined #minetest-dev |
| 15:18 |
MTDiscord |
<x2048> There's a multiplier of 2.5 applied to emissive_light here: https://github.com/minetest/minetest/blob/master/src/client/mapblock_mesh.cpp#L1561. |
| 16:59 |
|
behalebabo joined #minetest-dev |
| 17:28 |
|
Fleckenstein joined #minetest-dev |
| 17:34 |
|
appguru joined #minetest-dev |
| 17:48 |
|
CoolJar10 joined #minetest-dev |
| 18:38 |
|
appguru joined #minetest-dev |
| 18:39 |
MTDiscord |
<x2048> Any ideas about this 'if' in getInteriorLight? https://github.com/minetest/minetest/blob/master/src/client/mapblock_mesh.cpp#L106 |
| 18:53 |
MTDiscord |
<x2048> Looks like a leftover from legacy, and the reason is not clear from the logs. |
| 19:03 |
celeron55 |
i'll take a look |
| 19:05 |
celeron55 |
https://github.com/minetest/minetest/commit/f5fd4a0af1fef2e9cd3f7f368884349013a06dcc#diff-773af0bb916fbeab5135fa2e7d9ca54413bbbd7db33ae4f5cd147473cc8425cbL133 |
| 19:05 |
Pexin |
all I can tell is that https://github.com/minetest/minetest/blob/master/src/client/game.cpp#L3263 passes -1 as increment in 2 places |
| 19:06 |
Pexin |
which gets relayed to the file local func in mapblock_mesh |
| 19:06 |
celeron55 |
i think this commit that introduces the particular >0 explains it |
| 19:06 |
celeron55 |
i mean, explains the logic it's based on, and the logic it's based on has a comment that says "We don't know if light should undiminish from this particular 0. Thus, keep it at 0." |
| 19:07 |
celeron55 |
that comment is written by me... in 2010 |
| 19:08 |
celeron55 |
it's not likely whatever that logic comes from matters at all nowadays |
| 19:09 |
celeron55 |
probably has something to do with how lighting updates were done originally... maybe |
| 19:10 |
Pexin |
mathematically just removing the if does nothing, because it will still be floored at 0 either way |
| 19:11 |
|
asdflkj_sh joined #minetest-dev |
| 19:12 |
MTDiscord |
<x2048> If prevents adding increment if the previously calculated light is zero. For example, if I want to add glow for an entity which is in complete darkness. |
| 19:13 |
Pexin |
oh, yeah doi. sorry. |
| 19:15 |
celeron55 |
i'd say just get rid of it. but it needs some heavy testing as light is persistent |
| 19:15 |
celeron55 |
entity lighting isn't but nodes |
| 19:20 |
MTDiscord |
<x2048> This increment is only used in flat (non-smooth) light code (fixed value of 1) and selection mesh (fixed value of -1) |
| 19:21 |
celeron55 |
then it's not persistent |
| 19:23 |
MTDiscord |
<x2048> It's not. But in those cases the 'if' is important, otherwise non-solid nodes will glow in the dark with flat lighting. |
| 19:23 |
MTDiscord |
<x2048> non-solid = non-fast-faces |
| 19:38 |
sfan5 |
PSA: this year's serverlist statistics -> https://kitsunemimi.pw/tmp/serverlist_stats_2022-09-04.txt |
| 19:45 |
MTDiscord |
<x2048> Further digging into getInteriorLight(), this increment of 1 makes nodebox nodes appear lighter than solid nodes at the same map light level: https://i.imgur.com/NdUoJhO.png |
| 19:45 |
MTDiscord |
<x2048> (on the right side I remove the +1 from the increment) |
| 20:13 |
|
appguru joined #minetest-dev |
| 20:53 |
|
v-rob joined #minetest-dev |
| 21:09 |
MTDiscord |
<x2048> Added #12741 to change behavior of getInteriorLight, align brightness of solid and non-solid draw types and formally correct entity glow. |
| 21:09 |
ShadowBot |
https://github.com/minetest/minetest/issues/12741 -- [No squash] Corrections to entity and node light calculation by x2048 |
| 21:27 |
|
calcul0n joined #minetest-dev |
| 21:40 |
|
proller joined #minetest-dev |
| 22:31 |
|
YuGiOhJCJ joined #minetest-dev |
| 22:35 |
|
panwolfram joined #minetest-dev |
| 23:11 |
|
AliasStillTaken joined #minetest-dev |
| 23:32 |
|
kilbith joined #minetest-dev |
