| Time |
Nick |
Message |
| 00:02 |
|
diceLibrarian joined #minetest-dev |
| 00:05 |
|
Noisytoot joined #minetest-dev |
| 01:29 |
Zughy[m] |
meeting note created (23/10), please core devs state whether you're gonna attend |
| 01:31 |
|
panwolfram joined #minetest-dev |
| 01:47 |
|
freelikegnu joined #minetest-dev |
| 02:30 |
|
proller joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 04:02 |
|
Warr1024 joined #minetest-dev |
| 04:49 |
|
calcul0n joined #minetest-dev |
| 05:32 |
|
TheCoffeMaker joined #minetest-dev |
| 06:17 |
|
cranezhou joined #minetest-dev |
| 08:48 |
|
_Zaizen_[m] joined #minetest-dev |
| 09:14 |
|
MisterE[m] joined #minetest-dev |
| 09:14 |
|
_Zaizen_[m]1 joined #minetest-dev |
| 09:14 |
|
programmerjake joined #minetest-dev |
| 09:14 |
|
freshreplicant[m joined #minetest-dev |
| 09:14 |
|
fgaz joined #minetest-dev |
| 09:14 |
|
Goobax[m] joined #minetest-dev |
| 09:14 |
|
Goobax[m]1 joined #minetest-dev |
| 09:14 |
|
k327[m] joined #minetest-dev |
| 09:14 |
|
pjalsDaniel[m] joined #minetest-dev |
| 09:14 |
|
lebruhgamer[m] joined #minetest-dev |
| 09:14 |
|
schwarzwald[m] joined #minetest-dev |
| 09:14 |
|
Zughy[m] joined #minetest-dev |
| 09:51 |
nrz |
sfan5, which PR is blocked and you raged about it, i can take a look today |
| 09:54 |
MTDiscord |
<luatic> I don't remember sfan5 "raging" |
| 10:26 |
|
kilbith joined #minetest-dev |
| 10:45 |
sfan5 |
it already has an approval, don't worry |
| 10:52 |
|
Noisytoot joined #minetest-dev |
| 11:05 |
|
Noisytoot joined #minetest-dev |
| 11:18 |
|
Noisytoot joined #minetest-dev |
| 11:32 |
|
Noisytoot joined #minetest-dev |
| 11:46 |
|
Noisytoot joined #minetest-dev |
| 12:23 |
|
proller joined #minetest-dev |
| 12:26 |
|
Noisytoot joined #minetest-dev |
| 12:39 |
|
Noisytoot joined #minetest-dev |
| 13:10 |
nrz |
ok thanks sfan5 🙂 |
| 13:14 |
|
Noisytoot joined #minetest-dev |
| 13:24 |
|
Noisytoot joined #minetest-dev |
| 13:49 |
|
Noisytoot joined #minetest-dev |
| 14:01 |
|
Noisytoot joined #minetest-dev |
| 14:07 |
|
proller joined #minetest-dev |
| 14:13 |
|
Noisytoot joined #minetest-dev |
| 14:13 |
|
vampirefrog joined #minetest-dev |
| 14:27 |
|
jonadab joined #minetest-dev |
| 14:45 |
|
vampirefrog joined #minetest-dev |
| 14:49 |
|
Noisytoot joined #minetest-dev |
| 14:52 |
rubenwardy |
@x2048: https://old.reddit.com/r/Minetest/comments/y9v7q1/terrible_graphic_performance_on_linux_mint_193/ |
| 14:55 |
sfan5 |
merging #12795, #12882, #12867, #12877, #12789, #12874 |
| 14:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/12795 -- Fix formspec focus by Desour |
| 14:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/12882 -- Fix typos and en_US/en_GB inconsistency in files inside doc directory by Abdou-31 |
| 14:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/12867 -- guiChatConsole: fix the unicode characters crowded together on prompt by snowyu |
| 14:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/12877 -- Crash when shadow intensity is set to 0 |
| 14:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/12789 -- Revise bump_version.sh script to address shortcomings by sfan5 |
| 14:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/12874 -- Fix use of unassigned global "check" by TurkeyMcMac |
| 14:56 |
sfan5 |
in 10m |
| 14:56 |
sfan5 |
and ignore that 12877, it slipped in |
| 14:57 |
|
Noisytoot joined #minetest-dev |
| 14:57 |
|
Fixer joined #minetest-dev |
| 15:03 |
|
kilbith joined #minetest-dev |
| 15:06 |
nrz |
sfan5, if you have 5 mins #12885 is ready for a merge, i think it's a good startup on cleanups on the server part, i found pretty trivial things to fix to increase code quality |
| 15:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/12885 -- [NOSQUASH] refacto: Reduce exposure of StaticObjectList by nerzhul |
| 15:06 |
nrz |
i have other ideas in mind based on this PR but i prefer to wait it's integrated to continue and prevent to have a very big pr |
| 15:18 |
|
Noisytoot joined #minetest-dev |
| 16:44 |
|
Noisytoot joined #minetest-dev |
| 17:16 |
|
Noisytoot joined #minetest-dev |
| 17:29 |
|
vampirefrog joined #minetest-dev |
| 18:04 |
|
Desour joined #minetest-dev |
| 19:12 |
nrz |
is this normal in shadow rendered we check the node pointer and return instead of having an assertion to understand why we are asking a null node to be modified from rendered ? sounds more like a bug |
| 19:13 |
rubenwardy |
that sentence is unreadable |
| 19:13 |
nrz |
oops my bad |
| 19:13 |
nrz |
ShadowRenderer::removeNodeFromShadowList(scene::ISceneNode *node) => first condition node not null. |
| 19:13 |
rubenwardy |
I'm guessing you mean modifying a pointer to a node without checking for null? |
| 19:13 |
nrz |
that sounds a hacky bugfix for no reason, we should have an assert here |
| 19:14 |
nrz |
we should never ask to remove a null it doesn't make sense, same for add node it's impossible programatically in current code to have null there |
| 19:15 |
nrz |
i just check code path we have mandatory nodes passed to those function everytime , as the pointer is used before calling those functions |
| 19:25 |
nrz |
ah yeah we are really pushing nullptr to removeNodeFromShadowList... and testing that the parameter is right on this side, ouch |
| 19:38 |
|
vampirefrog joined #minetest-dev |
| 20:09 |
|
Noisytoot joined #minetest-dev |
| 20:28 |
|
pgimeno joined #minetest-dev |
| 20:44 |
|
Noisytoot joined #minetest-dev |
| 20:53 |
|
Alias joined #minetest-dev |
| 21:03 |
|
Noisytoot joined #minetest-dev |
| 22:17 |
|
Noisytoot joined #minetest-dev |
| 22:35 |
|
panwolfram joined #minetest-dev |
| 23:36 |
|
AliasAlreadyTake joined #minetest-dev |
