| Time |
Nick |
Message |
| 00:15 |
rubenwardy |
!title https://github.com/flathub/net.minetest.Minetest/pull/45 |
| 00:15 |
ShadowBot |
rubenwardy: Fix "Open User Data Directory" button not working by rubenwardy · Pull Request #45 · flathub/net.minetest.Minetest · GitHub |
| 00:36 |
|
LandarVargan joined #minetest-dev |
| 01:21 |
|
proller joined #minetest-dev |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 06:27 |
|
izzyb joined #minetest-dev |
| 06:39 |
|
fossdev2 joined #minetest-dev |
| 06:49 |
|
calcul0n joined #minetest-dev |
| 08:03 |
|
hmmmm joined #minetest-dev |
| 08:47 |
|
vampi joined #minetest-dev |
| 11:15 |
pgimeno |
rubenwardy: did you notice the edit in the last comment of flathub#45? |
| 11:15 |
rubenwardy |
? |
| 11:16 |
rubenwardy |
oh the comment |
| 11:16 |
rubenwardy |
yes |
| 11:17 |
|
vampi joined #minetest-dev |
| 11:18 |
rubenwardy |
not sure why it wouldn't save because it works for me |
| 11:24 |
rubenwardy |
added test instructions to OP, feel free to test |
| 11:25 |
rubenwardy |
also, GitHub user pop ups no longer close and block things, so annoying |
| 11:48 |
|
proller joined #minetest-dev |
| 13:57 |
rubenwardy |
sfan5: sanity check, it's correct to use a git LuaJIT rather than 2.1.0-beta3 right? See https://github.com/flathub/net.minetest.Minetest/pull/43 |
| 14:26 |
|
proller joined #minetest-dev |
| 15:06 |
|
proller joined #minetest-dev |
| 15:32 |
sfan5 |
generally yes |
| 15:39 |
|
fluxionary joined #minetest-dev |
| 16:11 |
|
vampi joined #minetest-dev |
| 16:15 |
Krock |
will merge #13133 and #13168 in 15 minutes |
| 16:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/13133 -- 8x block meshes by x2048 |
| 16:15 |
ShadowBot |
https://github.com/minetest/minetest/issues/13168 -- Improve the documentation for chat command definition in lua_api.txt. by kab0u |
| 16:15 |
|
LandarVargan joined #minetest-dev |
| 16:29 |
Krock |
merging |
| 16:31 |
Krock |
done |
| 16:39 |
|
kilbith joined #minetest-dev |
| 16:41 |
kilbith |
Krock: RE octablock merge: you should let the author decide if the PR is ready, there was still https://github.com/x2048/minetest/pull/8 pending for x2048' review |
| 16:42 |
Krock |
https://github.com/minetest/minetest/pull/13133#issuecomment-1409572536 |
| 16:42 |
kilbith |
yes but it's best to let x2048 decide what to do with it first |
| 16:44 |
Krock |
ok |
| 16:45 |
kilbith |
can you hard reset because I feel like it was too rushed |
| 16:46 |
kilbith |
I already cancelled the same type action of yours on one my repo because you rushed it too fast |
| 16:46 |
kilbith |
* of my |
| 16:47 |
Krock |
I won't do that because A) the time window expired B) lhofhansl requested a merge now for follow-up PRs C) repeated mentioning this for the additional PR you mentioned D) sfan5's review is stale and E) all requested changes and issues are resolved |
| 16:48 |
Krock |
if there is an issue with the PR, feel free to open a new ticket |
| 16:49 |
kilbith |
well I must say that your reasons sound like bad faith to me, it's primarily up to x2048 to decide |
| 16:49 |
kilbith |
don't do that again please |
| 16:49 |
kilbith |
and again, you did this type of action on my repos already |
| 16:49 |
Krock |
if they felt that something needs changing, they have the rights to add the WIP label which is the correct indication for delaying PRs |
| 17:04 |
|
kabou joined #minetest-dev |
| 17:14 |
|
vampi__ joined #minetest-dev |
| 17:48 |
pgimeno |
about LuaJIT versions: https://github.com/LuaJIT/LuaJIT/issues/665 |
| 18:43 |
|
kabou joined #minetest-dev |
| 20:54 |
|
proller joined #minetest-dev |
| 22:10 |
|
proller joined #minetest-dev |
| 22:22 |
|
calcul0n joined #minetest-dev |
| 22:25 |
|
kabou joined #minetest-dev |
| 23:21 |
|
proller joined #minetest-dev |
