| Time |
Nick |
Message |
| 01:31 |
|
PrairieWind joined #minetest-dev |
| 01:31 |
|
PrairieWind joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 05:32 |
|
calcul0n joined #minetest-dev |
| 06:33 |
|
Fleckenstein joined #minetest-dev |
| 07:43 |
|
vampirefrog joined #minetest-dev |
| 08:04 |
nrz |
great job for the release , team 🙂 |
| 08:22 |
|
Warr1024 joined #minetest-dev |
| 09:36 |
|
Noisytoot joined #minetest-dev |
| 12:45 |
|
tekakutli joined #minetest-dev |
| 13:25 |
|
Desour joined #minetest-dev |
| 14:48 |
|
fluxionary_ joined #minetest-dev |
| 16:00 |
|
tekakutli joined #minetest-dev |
| 16:15 |
|
tekakutli joined #minetest-dev |
| 17:05 |
|
lhofhansl joined #minetest-dev |
| 17:05 |
lhofhansl |
Merging #13385 in a few. |
| 17:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/13385 -- Allow large -z eye offsets by lhofhansl |
| 17:05 |
lhofhansl |
Oops... I meant #13393. |
| 17:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/13393 -- Do not call updateDrawList, updateDrawListShadow, and touchMapBlocks in the same frame by lhofhansl |
| 17:06 |
lhofhansl |
(not merging 13385) |
| 17:10 |
lhofhansl |
done |
| 17:11 |
lhofhansl |
Any comment on #13369 and #13314? Both are trivial. |
| 17:11 |
ShadowBot |
https://github.com/minetest/minetest/issues/13369 -- Reverse Z-coordinate in 3rd person front view by lhofhansl |
| 17:11 |
ShadowBot |
https://github.com/minetest/minetest/issues/13314 -- Add some instrumentation by lhofhansl |
| 17:36 |
|
Desour joined #minetest-dev |
| 18:26 |
|
PrairieWind joined #minetest-dev |
| 18:26 |
|
PrairieWind joined #minetest-dev |
| 18:52 |
|
olliy joined #minetest-dev |
| 19:29 |
|
PrairieWind joined #minetest-dev |
| 19:29 |
|
PrairieWind joined #minetest-dev |
| 20:05 |
|
proller joined #minetest-dev |
| 20:11 |
|
Desour joined #minetest-dev |
| 20:22 |
|
klbth joined #minetest-dev |
| 20:24 |
klbth |
rubenwardy: bad idea to ban IP adress ranges when you have a dynamic one |
| 20:43 |
|
klbth51 joined #minetest-dev |
| 20:48 |
|
vampirefrog joined #minetest-dev |
| 20:48 |
|
tekakutli joined #minetest-dev |
| 20:51 |
|
HuguesRoss3 left #minetest-dev |
| 21:01 |
Zughy[m] |
I've checked all TurkeyMcMac's PRs and, except for #13005, no one has got any conflict with master. Could be a good idea to focus on reviewing his PRs before any conflict emerge? Instead of just closing them I mean |
| 21:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/13005 -- Fix crack with animation by TurkeyMcMac |
| 21:02 |
Zughy[m] |
PRs: https://github.com/minetest/minetest/pulls/TurkeyMcMac |
| 21:02 |
Zughy[m] |
he was a core dev, so one approval is enough |
| 21:04 |
Desour |
^ only one approval would assume an implicit approval of him. AFAIK, we don't have implicit approvals |
| 21:06 |
Zughy[m] |
I mean, when a core dev makes a PR, the unwritten rule is that one approval is enough, so I don't see the difference in this case. If he's made the PR, it means he was sure of it |
| 21:08 |
Desour |
IIRC, the "one (non-self) approval is enough" rule only applies if the author merges, which is sadly not possible in this case |
| 21:16 |
|
fluxionary_ joined #minetest-dev |
| 21:32 |
|
moonmoon joined #minetest-dev |
| 21:44 |
MTDiscord |
<Jonathon> Rather than getting bogged down in policy, would seem better to just look them over at least. As for just merging them (if ok) setting a precident, one would think it's not likely to be an issue due to hopefully circumstances not being met again |
| 22:36 |
|
MTDiscord1 joined #minetest-dev |
