| Time |
Nick |
Message |
| 01:34 |
|
YuGiOhJCJ joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 05:08 |
|
calcul0n joined #minetest-dev |
| 09:33 |
|
tekakutli joined #minetest-dev |
| 10:47 |
|
appguru joined #minetest-dev |
| 11:14 |
|
proller joined #minetest-dev |
| 11:55 |
|
appguru joined #minetest-dev |
| 11:56 |
Zughy[m] |
celeron55: https://irc.minetest.net/minetest-dev/2023-05-01#i_6080728 |
| 12:20 |
|
Noisytoot joined #minetest-dev |
| 13:42 |
|
fluxionary joined #minetest-dev |
| 14:17 |
|
appguru joined #minetest-dev |
| 15:25 |
|
imi joined #minetest-dev |
| 15:34 |
|
Alias joined #minetest-dev |
| 15:45 |
|
Warr1024 joined #minetest-dev |
| 15:51 |
|
Warr1024 joined #minetest-dev |
| 15:54 |
|
Warr1024 joined #minetest-dev |
| 15:55 |
imi |
hi, as far as I can tell I fixed the issues found in code review: https://github.com/minetest/minetest_game/compare/master...imre84:minetest_game:master what do I do now? Do I need to squash? Do I need to open a new pull request? |
| 16:12 |
MTDiscord |
<luatic> You don't need to squash or open a separate PR. |
| 16:30 |
|
proller joined #minetest-dev |
| 16:38 |
Krock |
usually PRs are squashed on rebase-merge. there's a convenient button for maintainers that does that, so no need to worry. |
| 16:40 |
Krock |
about the slot count: I suppose that could be solved by using a scroll container, initialize a customizable amount of slots, fill them up and trim to the amount of occupied slots |
| 16:40 |
Krock |
although that might already be an overengineered approach |
| 17:02 |
imi |
currently I use a variable sized grid, with the minimum of 8*4 and if there are more items in the bones the grid grows |
| 18:19 |
|
nrz joined #minetest-dev |
| 18:27 |
|
nrz joined #minetest-dev |
| 18:37 |
|
appguru joined #minetest-dev |
| 19:42 |
|
proller joined #minetest-dev |
| 20:21 |
|
AFCM joined #minetest-dev |
| 22:32 |
|
panwolfram joined #minetest-dev |
| 23:52 |
|
AliasAlreadyTake joined #minetest-dev |
