| Time |
Nick |
Message |
| 00:17 |
|
behalebabo joined #minetest-dev |
| 00:35 |
|
behalebabo joined #minetest-dev |
| 00:43 |
|
freelikegnu joined #minetest-dev |
| 00:48 |
|
ShadowBot joined #minetest-dev |
| 02:25 |
|
YuGiOhJCJ joined #minetest-dev |
| 02:56 |
|
YuGiOhJCJ joined #minetest-dev |
| 03:37 |
|
fluxionary joined #minetest-dev |
| 04:00 |
|
MTDiscord joined #minetest-dev |
| 05:30 |
|
ivanbu joined #minetest-dev |
| 05:49 |
|
clavi joined #minetest-dev |
| 05:49 |
|
clavi joined #minetest-dev |
| 05:53 |
|
calcul0n_ joined #minetest-dev |
| 06:30 |
|
hmmmm joined #minetest-dev |
| 06:47 |
|
tekakutli joined #minetest-dev |
| 07:05 |
|
appguru joined #minetest-dev |
| 11:22 |
|
proller joined #minetest-dev |
| 11:56 |
|
appguru joined #minetest-dev |
| 11:56 |
|
appguru joined #minetest-dev |
| 12:02 |
|
appguru joined #minetest-dev |
| 12:38 |
|
appguru joined #minetest-dev |
| 13:00 |
|
tekakutli joined #minetest-dev |
| 13:11 |
|
appguru joined #minetest-dev |
| 14:06 |
|
appguru joined #minetest-dev |
| 14:17 |
|
proller joined #minetest-dev |
| 15:09 |
|
appguru joined #minetest-dev |
| 15:24 |
|
Desour joined #minetest-dev |
| 16:50 |
|
v-rob joined #minetest-dev |
| 17:13 |
|
Kimapr joined #minetest-dev |
| 17:42 |
|
appguru joined #minetest-dev |
| 17:43 |
appguru |
Hi. Would any core dev happen to have the time to review one (1) line of code? https://github.com/minetest/minetest/pull/13638#discussion_r1248124242 |
| 17:48 |
appguru |
wsor: do your triager permissions suffice to move the Minetest Game issue to the engine? |
| 17:49 |
*Ā celeron55 |
is taking a quick look |
| 17:49 |
wsor |
nope, try Zughy[m] |
| 17:49 |
wsor |
or c55 š¤· |
| 17:53 |
|
appguru1 joined #minetest-dev |
| 17:53 |
celeron55 |
it would require digging up the mapping of api functions to network packets to fully understand what's going on and what the intention of the obviously wrong -1 was |
| 17:54 |
celeron55 |
NO_ANIM is definitely obviously better than -1 |
| 17:55 |
celeron55 |
hmm... |
| 17:58 |
celeron55 |
isn't this where the problem actually occurs, once the value is -1? https://github.com/minetest/minetest/blob/cbc0fce6cacf5cbdabbfcf9a96cbf2e5bcd6a40d/src/client/content_cao.cpp#L1091 |
| 18:01 |
celeron55 |
maybe not. the animation logic isn't very easy to follow |
| 18:04 |
celeron55 |
the naming is silly also. isn't NO_ANIM the idle animation? |
| 18:07 |
Desour |
NO stands for natural organism idling simulation |
| 18:08 |
Desour |
so, do we finally get a way to make sam sit reliably? nice! |
| 18:16 |
celeron55 |
well, i'll just say if that one line fix seems to work by testing and doesn't seem to break other animation changes it's ok |
| 19:11 |
|
appguru joined #minetest-dev |
| 19:32 |
|
jojje joined #minetest-dev |
| 22:05 |
|
tekakutli joined #minetest-dev |
| 22:31 |
|
panwolfram joined #minetest-dev |
| 23:23 |
|
proller joined #minetest-dev |
| 23:33 |
|
Alias joined #minetest-dev |
