| Time |
Nick |
Message |
| 01:26 |
|
v-rob joined #minetest-dev |
| 03:44 |
|
v-rob joined #minetest-dev |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 05:00 |
|
whosit joined #minetest-dev |
| 05:50 |
|
v-rob joined #minetest-dev |
| 06:33 |
|
SFENCE_arch joined #minetest-dev |
| 06:50 |
|
SFENCE joined #minetest-dev |
| 08:01 |
MTDiscord |
<cscscscscscscscscscscscscscscscs> Zughy: beyond just the roadmap, is there a reason you truly decided to close mine? It seemed quite sudden |
| 08:02 |
MTDiscord |
<cscscscscscscscscscscscscscscscs> It does fix a bug actually, it just also happens to add a new feature. |
| 08:03 |
MTDiscord |
<cscscscscscscscscscscscscscscscs> I would like more insight than just it suddenly being closed with more rule-aligning reasons than genuine ones |
| 08:04 |
MTDiscord |
<cscscscscscscscscscscscscscscscs> If i slipped in trackpad support, could you reconsider opening it? |
| 09:54 |
[MatrxMT] |
<Zughy> You asked multiple times in here for someone to review it and nobody did, meaning either nobody cares or they have different priorities. It adds a feature, so roadmap rules apply |
| 10:14 |
celeron55 |
it's no big deal really. you should make a new PR with only the bugfixes and go from there |
| 10:16 |
celeron55 |
(ending up with too much stuff in a PR happens to everyone. and every time the solution is the same) |
| 12:09 |
|
SFENCE joined #minetest-dev |
| 12:15 |
|
SFENCE joined #minetest-dev |
| 12:35 |
|
SFENCE joined #minetest-dev |
| 12:40 |
|
SFENCE joined #minetest-dev |
| 12:41 |
|
grorp joined #minetest-dev |
| 12:42 |
grorp |
merging #15392 in 15 min |
| 12:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/15392 -- Implement support for FSAA in combination with post-processing by grorp |
| 12:58 |
|
SFENCE joined #minetest-dev |
| 13:10 |
grorp |
merged |
| 13:11 |
grorp |
now I can enable all those fancy post-processing effects without being plagued by aliasing artifacts, great! |
| 13:18 |
|
Desour joined #minetest-dev |
| 13:40 |
[MatrxMT] |
<Zughy> Let's go grorp :D |
| 13:59 |
|
SFENCE joined #minetest-dev |
| 15:03 |
|
grorp left #minetest-dev |
| 15:08 |
|
v-rob joined #minetest-dev |
| 16:00 |
|
v-rob joined #minetest-dev |
| 17:54 |
|
hwpplayer1 joined #minetest-dev |
| 19:08 |
|
vampirefrog joined #minetest-dev |
| 19:16 |
|
SFENCE joined #minetest-dev |
| 19:18 |
|
v-rob joined #minetest-dev |
| 19:31 |
|
v-rob joined #minetest-dev |
| 19:33 |
|
SFENCE joined #minetest-dev |
| 20:50 |
Krock |
grorp: the buildbot must be drunk then. The packet assets.zip contains your changes in dlg_settings.lua AND the mod security changes from ea4ae55e2 |
| 20:55 |
|
v-rob joined #minetest-dev |
| 20:57 |
|
SFENCE joined #minetest-dev |
| 21:01 |
[MatrxMT] |
<grorp> what |
| 21:02 |
[MatrxMT] |
<grorp> can you confirm that the PR branch actually doesn't contain the commit? perhaps I just got that wrong |
| 21:05 |
Krock |
your branch is based on 4c44942, which is 2 commits older than ea4ae55 |
| 21:05 |
[MatrxMT] |
<grorp> because I've confirmed that the Lua changes from that commit are included in the assets.zip of the CI APK and it doesn't make much sense |
| 21:05 |
Krock |
so the CI is drunk after all |
| 21:11 |
[MatrxMT] |
<grorp> ok, rebased and pushed the quick workaround, hopefully that'll get us a working APK |
| 21:12 |
[MatrxMT] |
<grorp> obviously to be reverted before merge |
| 21:14 |
Krock |
thanks. I'll give it a try perhaps tomorrow |
| 21:59 |
MTDiscord |
<luatic> Krock: I take it you're planning to do a full review of #14933? |
| 21:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/14933 -- Implement an editor to customize the touchscreen controls by grorp |
| 22:28 |
|
SFENCE joined #minetest-dev |
| 22:47 |
sfan5 |
@grorp Krock: gh actions runs from a revision that is the PR merged into the master branch |
| 23:02 |
sfan5 |
pushing https://github.com/minetest/minetest/commit/f493e73aeb65a0f4f4ad8a93ef4f4dbf197d606d once a few CI runs complete |
| 23:29 |
|
SFENCE joined #minetest-dev |
| 23:32 |
|
panwolfram joined #minetest-dev |
| 23:47 |
|
SFENCE joined #minetest-dev |
