| Time |
Nick |
Message |
| 00:05 |
|
Eragon joined #minetest-dev |
| 00:07 |
MTDiscord |
<luatic> can we consolidate our usage of _IRR_DEBUG_BREAK_IF and assert |
| 00:07 |
MTDiscord |
<luatic> is there a major downside to just replacing _IRR_DEBUG_BREAK_IF with assert everywhere that i'm missing |
| 00:09 |
MTDiscord |
<josiah_wi> Is it possible Irrlicht was originally intended to work with a C compiler? |
| 00:09 |
MTDiscord |
<josiah_wi> C doesn't have a built-in debug assertion so everybody writes their own macro. I'm guessing that's the historical reason behind it. |
| 00:15 |
|
v-rob joined #minetest-dev |
| 00:28 |
|
SFENCE joined #minetest-dev |
| 00:55 |
|
fluxionary joined #minetest-dev |
| 01:03 |
|
SFENCE joined #minetest-dev |
| 01:26 |
MTDiscord |
<luatic> thought: what if funny graphs like https://www.luanti.org/benchmarks/dev/bench/ but for compile times, or even better, a bot that warns us if a PR shows significant increase in CI compilation times; surely there gotta be some premade solutions for this (does someone know a good one)? |
| 01:37 |
|
SFENCE joined #minetest-dev |
| 02:11 |
MTDiscord |
<warr1024> If you can detect whether you're in CI mode or not, you could presumably just cause the build to fail if it goes over a certain time limit, like with a ( sleep N; killall gcc )& or something. Increases to allowed compile time would have to be included in relevant PRs and subject to review then. |
| 02:13 |
|
SFENCE joined #minetest-dev |
| 02:47 |
|
SFENCE joined #minetest-dev |
| 03:20 |
|
SFENCE joined #minetest-dev |
| 03:25 |
|
v-rob joined #minetest-dev |
| 03:57 |
|
SFENCE joined #minetest-dev |
| 04:15 |
|
SFENCE joined #minetest-dev |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 05:31 |
|
v-rob joined #minetest-dev |
| 07:00 |
|
v-rob joined #minetest-dev |
| 08:42 |
|
fluxionary joined #minetest-dev |
| 09:08 |
|
fluxionary joined #minetest-dev |
| 09:32 |
|
hwpplayer1 joined #minetest-dev |
| 10:14 |
sfan5 |
@luatic there is lots more in irrlicht that could be cleaned up if we properly "merged" the code, making it no longer act like a separate cmake project. so that irrlicht code can include headers from mt code |
| 10:15 |
sfan5 |
to allow using our logging system, sanity_check et al, string helpers, ... |
| 10:17 |
sfan5 |
but yes we can replace _IRR_DEBUG_BREAK_IF with assert right now |
| 10:27 |
|
fluxionary joined #minetest-dev |
| 11:58 |
|
hwpplayer1 joined #minetest-dev |
| 12:30 |
sfan5 |
merging #15481, #15489, #15488, #15493 sooner or later |
| 12:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/15481 -- Fix script security path normalization in presence of links by sfan5 |
| 12:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/15489 -- Use `add_compile_options` where appropriate by JosiahWI |
| 12:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/15488 -- Use CMake `list` directives where appropriate by JosiahWI |
| 12:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/15493 -- Less explicit memory management in irrlicht image writer classes by HybridDog |
| 12:35 |
MTDiscord |
<siliconsniffer> Can you take a quick look at #15486 if you have the time? |
| 12:35 |
ShadowBot |
https://github.com/minetest/minetest/issues/15486 -- Adopt #13446 server favorite button by siliconsniffer |
| 12:38 |
|
qur joined #minetest-dev |
| 12:40 |
sfan5 |
unfortunately no |
| 12:43 |
|
YuGiOhJCJ joined #minetest-dev |
| 13:06 |
|
SFENCE joined #minetest-dev |
| 13:27 |
MTDiscord |
<siliconsniffer> No problem, don't want to stress either - everything has its time =) |
| 14:33 |
|
hwpplayer1 joined #minetest-dev |
| 16:52 |
|
v-rob joined #minetest-dev |
| 18:22 |
|
SFENCE joined #minetest-dev |
| 18:50 |
|
SFENCE joined #minetest-dev |
| 19:21 |
[MatrxMT] |
<Zughy> Thanks josiah_wi for the reviews c: |
| 19:34 |
|
SFENCE joined #minetest-dev |
| 19:52 |
|
SFENCE joined #minetest-dev |
| 20:18 |
MTDiscord |
<josiah_wi> My pleasure. I compile on MSVC with a vcpkg.json myself, so I think I probably have helpful input on those docs. |
| 20:51 |
|
v-rob joined #minetest-dev |
| 21:24 |
|
YuGiOhJCJ joined #minetest-dev |
| 22:07 |
|
v-rob joined #minetest-dev |
| 23:02 |
|
Sharpman joined #minetest-dev |
| 23:33 |
|
panwolfram joined #minetest-dev |
| 23:34 |
|
v-rob joined #minetest-dev |
