| Time |
Nick |
Message |
| 00:35 |
|
exio4 joined #minetest-doc |
| 00:38 |
exio4 |
on https://github.com/minetest/minetest/issues/6535, is recent_chat_size a good name for a setting which sets the size of the recent buffer? it was hardcoded to six in the past |
| 00:38 |
exio4 |
asking about possible guidelines I haven't checked :) |
| 00:42 |
Shara |
Hi exio4 |
| 00:42 |
exio4 |
hello Shara! |
| 00:43 |
Shara |
recent_ makes me thing of a value it was previously set to, not the current value |
| 00:43 |
Shara |
But that might just be me. Struggling to think of something better. |
| 00:44 |
rubenwardy |
recent chat does sound odd |
| 00:44 |
rubenwardy |
size too |
| 00:44 |
rubenwardy |
worth seeing if it's mentioned elsewhere, maybe |
| 00:44 |
Shara |
That PR also seems to have abunch of unrelated things changed? |
| 00:44 |
rubenwardy |
anyway, night o/ |
| 00:44 |
Shara |
Good night, rubenwardy :) |
| 00:45 |
red-001 |
Shara, just the update script |
| 00:46 |
Shara |
Also some documentation. I've prviously been told to make seperate PRs for such things |
| 00:46 |
Shara |
But what do I know? |
| 00:46 |
exio4 |
I can remove it from the PR, no problem (cc: red-001) |
| 00:46 |
rubenwardy |
Shara, looks like they ran the update script |
| 00:47 |
rubenwardy |
ah |
| 00:47 |
exio4 |
but it's just the update script |
| 00:47 |
rubenwardy |
Shara, minetest.conf.example is auto-generated from the builtin/settingtypes.txt file |
| 00:47 |
exio4 |
and there were a few previous changes that had not been included in the past commits |
| 00:47 |
rubenwardy |
previous PRs forgot to add settings to minetest.conf.example, so when the script was added it been added now |
| 00:47 |
Shara |
I wasn't looking at that, but it's not important anyway |
| 00:47 |
rubenwardy |
there are a few possible mistakes though |
| 00:48 |
Shara |
Still trying to think of a better name |
| 00:48 |
exio4 |
I don't really feel qualified to come up for reasonable names to things, I am a programmer, the hardest part of programming is naming :p |
| 00:49 |
Shara |
It's something more like chat_lines_displayed... but that is long and ikky |
| 00:50 |
Shara |
chat_lines? |
| 00:53 |
exio4 |
I don't know, this is only for th recent stuff (iow, the messages shown outside the console) |
| 00:54 |
exio4 |
chat_lines sounds like limiting the chat buffer completely, like you won't be able to access messages past certain point |
| 00:54 |
Shara |
Yea, that's why I tagged on _displayed. |
| 00:54 |
Shara |
Maybe one of the others here will have a better idea anyway |
| 00:54 |
exio4 |
chat_lines_displayed_by_default :p |
| 00:55 |
red-001 |
unk_232 |
| 00:56 |
Shara |
Why are we giving unk a number? |
| 00:57 |
|
red-001 left #minetest-doc |
| 00:57 |
exio4 |
I can run pwgen and come up with a few names if needed :P |
| 00:57 |
|
red-001 joined #minetest-doc |
| 01:03 |
Shara |
Probably as good as anything I can come up with at this time of night :P |
| 01:22 |
unk |
now I'm unk_232? lol |
| 01:44 |
exio4 |
paramat suggested to use _lines too |
| 01:44 |
exio4 |
maybe recent_chat_lines? |
| 01:47 |
Shara |
Maybe |
| 01:54 |
exio4 |
will wait until tomorrow, to see if there are better/different suggestions, but recent_chat_lines looks fine to me |
| 02:08 |
Shara |
Yea, I think it's fine. |
| 17:25 |
|
Krock joined #minetest-doc |
| 22:23 |
|
rubenwardy joined #minetest-doc |
