| Time |
Nick |
Message |
| 00:06 |
MTDiscord |
<Benrob0329> How does everyone feel about the current state of the Template/HOWTO PR? ( @GreenXenith that includes you) |
| 00:06 |
MTDiscord |
<GreenXenith> I think its missing a lot but it can be filled in later |
| 00:07 |
MTDiscord |
<Benrob0329> Could you mark it as ready for review then? (ie unmark it as Draft) |
| 00:08 |
MTDiscord |
<Jonathon> benrob: dunno if you looked at github lately, thoughts on reject/etc label? |
| 00:08 |
MTDiscord |
<Benrob0329> I mean, I guess I can but I feel like that's bad practice |
| 00:08 |
MTDiscord |
<GreenXenith> done |
| 00:08 |
MTDiscord |
<Benrob0329> @wsor Seems reasonable |
| 00:08 |
MTDiscord |
<Benrob0329> We inherent either some github default tags or MT ones |
| 00:09 |
MTDiscord |
<Benrob0329> So we might have those already |
| 00:09 |
MTDiscord |
<Benrob0329> App hasn't contested after 2 days, are we good if I merge the new Template? |
| 00:12 |
MTDiscord |
<Benrob0329> @wsor Maybe instead of just "rejected" we should have more specific labels: "out of scope", "poor quality", and "abandoned" |
| 00:13 |
MTDiscord |
<Jonathon> i dont care what its named, just the concept |
| 00:13 |
MTDiscord |
<Benrob0329> Again, none of these need to be permanent, but they should give someone scanning the issues/PRs an idea of why something was closed |
| 00:13 |
MTDiscord |
<Jonathon> i.e. label to tell dont re open vs re open if commited to again |
| 00:14 |
MTDiscord |
<Benrob0329> maybe don't add "poor quality", that seems more like something that'd just be worked on |
| 00:16 |
MTDiscord |
<Benrob0329> Merging https://github.com/minetest/minetest_docs/pull/20 in 5 |
| 00:18 |
MTDiscord |
<Benrob0329> @wsor WIP and Ready For Review tags seem redundant, as Github has draft PRs |
| 00:18 |
MTDiscord |
<Benrob0329> It's either a draft, and thus WIP, or not, and thus ready for review |
| 00:18 |
MTDiscord |
<Jonathon> why the heck are you pinging me about that? |
| 00:19 |
MTDiscord |
<Benrob0329> I figured you had been the one managing the tags |
| 00:19 |
MTDiscord |
<Jonathon> .....havent touched them in this org if i recall correctly |
| 00:19 |
MTDiscord |
<Benrob0329> Also, why do we have a documentation tag, it's all documentation |
| 00:20 |
MTDiscord |
<GreenXenith> lol |
| 00:20 |
MTDiscord |
<Jonathon> is there a audit log in github? |
| 00:20 |
MTDiscord |
<Benrob0329> If it's not documentation, then it's meta or build system related, which should be the tags we add |
| 00:20 |
MTDiscord |
<GreenXenith> a lot of tags are stock |
| 00:21 |
MTDiscord |
<Benrob0329> wsor: Commit audit or settings? |
| 00:21 |
MTDiscord |
<Jonathon> like to see who added the tags |
| 00:26 |
MTDiscord |
<GreenXenith> should have squashed that |
| 00:27 |
MTDiscord |
<GreenXenith> #feeds works though |
| 00:28 |
MTDiscord |
<Benrob0329> ¯_(ツ)_/¯ |
| 00:31 |
MTDiscord |
<Benrob0329> I'd like to close 26 as wontfix since we don't have any other good options |
| 00:33 |
MTDiscord |
<Jonathon> sure |
| 05:00 |
|
MTDiscord joined #minetest-docs |
| 05:48 |
|
erlehmann joined #minetest-docs |
| 08:27 |
MTDiscord |
<luatic> This is a kludge. Can't we have something like a macro for it? asciidoc === function_name Description of the function. ==== Usage ---- return_values = function_name(argument1, argument2) ---- ==== Arguments [%autowidth, frame=none] |=== | `argument1` | `type` | Argument description. | `argument1` | `type` | Argument description. |=== OR _None_ ==== Returns [%autowidth, frame=none] |=== | `return_name` | `type` |
| 08:27 |
MTDiscord |
| Return value description. |=== |
| 08:28 |
MTDiscord |
<luatic> this formatting should be done by stylesheets, not by Adoc kludges |
| 08:29 |
MTDiscord |
<luatic> I can live with the headers, those are required. The usage is missing a [source,lua] I believe. But the [%autowidth, frame=none] should be set as a default for all tables or the like. |
| 08:51 |
MTDiscord |
<GreenXenith> already asked for a macro, not happening til later |
| 08:51 |
MTDiscord |
<GreenXenith> usage doesnt have a source on purpose |
| 08:52 |
MTDiscord |
<GreenXenith> Im also not sure why you call it a kludge |
| 08:52 |
MTDiscord |
<GreenXenith> Its just asciidoc |
| 08:52 |
MTDiscord |
<GreenXenith> its a perfectly valid way to write it |
| 08:52 |
MTDiscord |
<GreenXenith> its just tedious |
| 08:52 |
MTDiscord |
<GreenXenith> kludge is the wrong word entirely |
| 12:16 |
|
erlehmann joined #minetest-docs |
| 12:45 |
|
erlehmann joined #minetest-docs |
| 13:14 |
MTDiscord |
<exe_virus> Sure, make it less tedious, and more readable, that's always** the goal |
| 13:35 |
|
erlehmann joined #minetest-docs |
| 14:15 |
MTDiscord |
<Benrob0329> It's not a kludge, its per table styling. It will render into various formats just fine, it's not like it's HTML specific or anything (afaik) |
| 14:17 |
MTDiscord |
<luatic> This is mushing model & view together |
| 14:17 |
MTDiscord |
<luatic> And while it may not be HTML-specific, it certainly is rendering-specific |
| 14:19 |
MTDiscord |
<Benrob0329> Since when was AsciiDoc a styling free language? It's got plenty of knobs to tweak things on a global and per-block basis if needed |
| 14:20 |
MTDiscord |
<Benrob0329> Its not nitty gritty tweaking for most things, but its there |
| 14:21 |
MTDiscord |
<Benrob0329> That being said, setting autowidth and noframe globally would be nice |
| 14:21 |
MTDiscord |
<luatic> Something like emphasis or strikethrough is both styling and semantics |
| 14:22 |
MTDiscord |
<luatic> "autowidth" and "frame" carry no semantics whatsoever, they are purely visuals |
| 14:23 |
MTDiscord |
<Benrob0329> There are times when we'll need to set something purely visual (e.g. [horizontal]), we just need to avoid things that are specific to a single renderer. |
| 14:24 |
MTDiscord |
<Benrob0329> But, if we can set things on a global level thats better |
| 14:25 |
MTDiscord |
<Benrob0329> I didn't see a good way of doing that though from within asciidoc, but maybe its about time we got ourselves an HTML style |
| 14:35 |
|
erlehmann joined #minetest-docs |
| 15:32 |
|
erlehmann joined #minetest-docs |
| 15:42 |
MTDiscord |
<exe_virus> I vote not whatever I'm using for nodecast haha |
| 16:03 |
|
erlehmann joined #minetest-docs |
| 16:09 |
|
erlehmann joined #minetest-docs |
| 16:13 |
MTDiscord |
<j45> i think #12 is done |
| 17:00 |
|
Yad joined #minetest-docs |
| 17:48 |
|
appguru joined #minetest-docs |
| 19:33 |
|
appguru joined #minetest-docs |
