| Time |
Nick |
Message |
| 01:54 |
|
Miner_48er joined #minetest-hub |
| 03:59 |
|
Lupercus joined #minetest-hub |
| 04:07 |
|
DatNinja joined #minetest-hub |
| 04:27 |
|
Lupercus left #minetest-hub |
| 04:42 |
|
olliy joined #minetest-hub |
| 05:21 |
|
BillyS joined #minetest-hub |
| 07:30 |
|
calcul0n joined #minetest-hub |
| 08:00 |
|
ShadowNinja joined #minetest-hub |
| 08:24 |
|
hlqkj joined #minetest-hub |
| 08:56 |
|
Rafi59 left #minetest-hub |
| 08:57 |
|
Rafi59_ joined #minetest-hub |
| 08:58 |
|
Rafi59 joined #minetest-hub |
| 10:59 |
|
_Zaizen_ joined #minetest-hub |
| 11:49 |
|
Fixer joined #minetest-hub |
| 12:39 |
|
Fixer_ joined #minetest-hub |
| 12:49 |
|
Megaf joined #minetest-hub |
| 13:35 |
|
DatNinja joined #minetest-hub |
| 13:45 |
|
calcul0n_ joined #minetest-hub |
| 14:59 |
|
aerozoic joined #minetest-hub |
| 15:13 |
|
hlqkj joined #minetest-hub |
| 16:37 |
|
fluxflux joined #minetest-hub |
| 16:57 |
|
GreenXenith joined #minetest-hub |
| 17:13 |
|
Fixer joined #minetest-hub |
| 18:19 |
|
_Zaizen_ joined #minetest-hub |
| 20:10 |
|
Conradish006 joined #minetest-hub |
| 20:32 |
|
Rafi59 joined #minetest-hub |
| 20:50 |
scr267 |
sfan5, sorry maybe I can pester you here instead of on github ;) |
| 20:50 |
sfan5 |
hi |
| 20:51 |
scr267 |
I just thought that it might be useful to add validation of input since the functions are basically 'public'... not 100% sure how classes and their scopes work in LUA though... hard for me to comment clearly on that. |
| 20:52 |
scr267 |
Also, I'll definitely look into the biome_lib issue to see if I can figure out why its sending an empty value. |
| 20:53 |
scr267 |
Don't want to give you more work however, so er... I could create a pull request if you like. |
| 20:53 |
scr267 |
But if you really think its innapropriate then I'll leave it at that. :) |
| 20:54 |
sfan5 |
there isn't a really a nice way to check if the functions works other than calling them for every possible input value and checking that they don't crash |
| 20:54 |
sfan5 |
doing so would be fine in an optionally-enabled validation mode IMO |
| 20:55 |
scr267 |
This is off topic but is Lua strictly typed like C++? |
| 20:55 |
rubenwardy |
no lol |
| 20:55 |
scr267 |
I just thought that could avoid pitfalls like this, but ... even then we can't guarantee null values. |
| 20:55 |
rubenwardy |
also, the C++ code should check that lua provides the correct types. Lua provides `lua_check*` for this purpose |
| 20:56 |
scr267 |
Ok. |
| 20:56 |
scr267 |
Fair enough, thanks for your input ! :) |
| 20:56 |
rubenwardy |
"should" doesn't mean it always does |
| 20:57 |
rubenwardy |
have you found instances where it doesn't? Is that what you mean by "validation of input"? |
| 20:58 |
scr267 |
rubenwardy, no but I keep running into issues with various mods and/or APIs where some functions receive null values and crash the server. |
| 20:59 |
scr267 |
Probably some bad combination between various versions of mods. |
| 21:24 |
|
_Zaizen_ joined #minetest-hub |
| 21:32 |
|
Miner_48er joined #minetest-hub |
| 22:24 |
|
hlqkj_ joined #minetest-hub |
| 23:40 |
|
lisac joined #minetest-hub |
