| Time |
Nick |
Message |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 04:18 |
|
MTDiscord joined #luanti-dev |
| 04:47 |
|
MTDiscord1 joined #luanti-dev |
| 07:51 |
|
YuGiOhJCJ joined #luanti-dev |
| 08:15 |
|
ivanbu joined #luanti-dev |
| 09:50 |
|
YuGiOhJCJ joined #luanti-dev |
| 10:46 |
|
turtleman joined #luanti-dev |
| 11:55 |
|
PtiLuky joined #luanti-dev |
| 12:52 |
|
SFENCE joined #luanti-dev |
| 12:58 |
|
Desour joined #luanti-dev |
| 13:16 |
|
SFENCE joined #luanti-dev |
| 13:18 |
|
SFENCE joined #luanti-dev |
| 13:26 |
|
SFENCE joined #luanti-dev |
| 13:29 |
|
SFENCE joined #luanti-dev |
| 13:32 |
|
SFENCE joined #luanti-dev |
| 13:41 |
|
SFENCE joined #luanti-dev |
| 13:50 |
|
Eragon joined #luanti-dev |
| 13:51 |
|
SFENCE joined #luanti-dev |
| 14:13 |
|
SFENCE joined #luanti-dev |
| 14:17 |
|
SFENCE joined #luanti-dev |
| 14:19 |
|
SFENCE joined #luanti-dev |
| 14:25 |
|
SFENCE joined #luanti-dev |
| 14:28 |
|
SFENCE joined #luanti-dev |
| 14:54 |
sfan5 |
merging #16300, #16308, #16303 in 10m or more |
| 14:54 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16300 -- Use unique_ptr for trivial ownership by PtiLuky |
| 14:54 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16308 -- Remove obsolete `SMeshBuffer.h` by appgurueu |
| 14:54 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16303 -- Do not block in httpfetch_request_clear() by sfan5 |
| 14:59 |
|
PtiLuky joined #luanti-dev |
| 15:01 |
PtiLuky |
Desour to me "Avoid passing non-const references to functions" sounds more like "in favor of const ref whenever possible". |
| 15:01 |
PtiLuky |
For pointers vs ref, the information of "the nullability has been checked previously" sounds more important and would be lost if raw pointers has been used everywhere... |
| 15:01 |
PtiLuky |
But I guess this is some coding style choice, I can adapt to this for next PR, sorry |
| 15:07 |
Desour |
hm, that's also a way one could read it. but I'm pretty sure it's a dislike against references, as it's in the "C++ features" section. it's also how it's been interpreted by most people so far, AFAIK. |
| 15:08 |
Desour |
anyway, as said, in your PR it's fine imo. I just wanted to let you know that replacing raw ptrs with references everywhere would probably not be welcomed and spare you of useless work :) |
| 15:09 |
PtiLuky |
Yes yes, understood, will avoid changing this kind of things then |
| 15:25 |
|
SFENCE joined #luanti-dev |
| 15:42 |
|
SFENCE joined #luanti-dev |
| 16:09 |
|
alias joined #luanti-dev |
| 16:24 |
|
SFENCE joined #luanti-dev |
| 16:34 |
|
Desour joined #luanti-dev |
| 16:35 |
|
SFENCE joined #luanti-dev |
| 16:37 |
|
Krock joined #luanti-dev |
| 16:38 |
|
SFENCE joined #luanti-dev |
| 16:43 |
|
SFENCE joined #luanti-dev |
| 17:01 |
MTDiscord |
<exe_virus> I also like references over raw pointers for the same reason, so would approve such a thing |
| 17:05 |
Krock |
I'd prefer references to have the -> notation too such that it's clear that a level of indirection happens |
| 17:06 |
Krock |
(but that's a design choice) |
| 17:18 |
|
SFENCE joined #luanti-dev |
| 17:27 |
|
SFENCE joined #luanti-dev |
| 17:38 |
MTDiscord |
<luatic> i too like to use references if possible. i think there is a benefit to them not using -> notation: it's easy to change something to be a (const) reference. |
| 17:46 |
|
SFENCE joined #luanti-dev |
| 17:51 |
|
SFENCE joined #luanti-dev |
| 18:11 |
|
SFENCE joined #luanti-dev |
| 18:30 |
|
SFENCE joined #luanti-dev |
| 18:44 |
|
SFENCE joined #luanti-dev |
| 20:01 |
|
Guest93 joined #luanti-dev |
| 20:12 |
|
celeron21 joined #luanti-dev |
| 20:15 |
|
guset joined #luanti-dev |
| 22:07 |
|
imi joined #luanti-dev |
| 22:33 |
|
panwolfram joined #luanti-dev |
| 23:08 |
|
Eragon joined #luanti-dev |
