| Time |
Nick |
Message |
| 00:03 |
|
SFENCE joined #luanti-dev |
| 00:40 |
|
SFENCE joined #luanti-dev |
| 02:08 |
|
SFENCE joined #luanti-dev |
| 02:32 |
|
aliasalreadytake joined #luanti-dev |
| 02:43 |
|
SFENCE joined #luanti-dev |
| 03:21 |
|
SFENCE joined #luanti-dev |
| 03:39 |
|
SFENCE joined #luanti-dev |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 04:12 |
|
SFENCE joined #luanti-dev |
| 04:39 |
|
SFENCE joined #luanti-dev |
| 04:49 |
MTDiscord |
<sfence> Technically on server side we have no way how to react on player collision with something? Only entity can react to collision with player, node, etc? Am I right? |
| 04:55 |
MTDiscord |
<wsor4035> (take this with a grain of salt, might be wrong) believe that to be the case, something like this adoption needed pr would be needed https://github.com/luanti-org/luanti/pull/6219 |
| 05:12 |
|
SFENCE joined #luanti-dev |
| 05:45 |
|
SFENCE joined #luanti-dev |
| 06:18 |
|
SFENCE joined #luanti-dev |
| 06:26 |
|
SFENCE joined #luanti-dev |
| 06:32 |
|
Eragon joined #luanti-dev |
| 06:46 |
|
Eragon_ joined #luanti-dev |
| 06:48 |
|
PtiLuky joined #luanti-dev |
| 07:03 |
|
Eragon joined #luanti-dev |
| 07:18 |
|
SFENCE joined #luanti-dev |
| 07:42 |
|
SFENCE joined #luanti-dev |
| 08:12 |
|
SFENCE joined #luanti-dev |
| 08:12 |
|
YuGiOhJCJ joined #luanti-dev |
| 08:29 |
|
SFENCE joined #luanti-dev |
| 09:09 |
|
SFENCE joined #luanti-dev |
| 09:23 |
|
SFENCE joined #luanti-dev |
| 09:28 |
|
PtiLuky joined #luanti-dev |
| 09:52 |
|
SFENCE joined #luanti-dev |
| 09:55 |
PtiLuky |
Hi, |
| 09:55 |
PtiLuky |
sfan5 lhofhansl (and others!) I want to discuss the PR https://github.com/luanti-org/luanti/pull/16329 to avoid polluting the PR with arguing. |
| 09:55 |
PtiLuky |
I still don't agree with sfan5 comment, I believe offering the option to have a shader that do not use the _MainShaderUniformSetter_ but its own setter instead is a good design choice, and I find alternatives worse to do... |
| 09:56 |
PtiLuky |
But I do agree "responsibility of the caller to create the callbacks (in general)" was a bad suggestion I did, you are right |
| 09:57 |
PtiLuky |
About recompiling: I do not understand your point, in this PR I added a irr_ptr<Callback> field to the shader_info struct, and like this, recompilation of the shader can be done without any issue, even if some shader have their own callbacks, what would be the issue? |
| 09:58 |
PtiLuky |
I'd be open to design alternative, but currently to me this callback override still seems the cleanest solution yet |
| 10:04 |
sfan5 |
please keep the discussion in the PR |
| 10:05 |
PtiLuky |
ok |
| 10:15 |
|
SFENCE joined #luanti-dev |
| 10:22 |
sfan5 |
if you want I can PR the necessary changes to adjust the way it works to my preference, too |
| 10:26 |
|
SFENCE joined #luanti-dev |
| 10:27 |
PtiLuky |
I am totally fine with that too :) |
| 11:00 |
|
SFENCE joined #luanti-dev |
| 11:17 |
|
SFENCE joined #luanti-dev |
| 11:18 |
|
turtleman joined #luanti-dev |
| 12:44 |
|
SFENCE joined #luanti-dev |
| 13:19 |
|
SFENCE joined #luanti-dev |
| 13:46 |
|
SFENCE joined #luanti-dev |
| 14:55 |
|
Desour joined #luanti-dev |
| 15:35 |
|
alias joined #luanti-dev |
| 16:51 |
|
SFENCE joined #luanti-dev |
| 17:11 |
|
SFENCE joined #luanti-dev |
| 18:14 |
|
SFENCE joined #luanti-dev |
| 19:23 |
|
Desour joined #luanti-dev |
| 20:38 |
|
fluxionary joined #luanti-dev |
| 21:15 |
|
citrons joined #luanti-dev |
| 21:17 |
|
SFENCE joined #luanti-dev |
| 22:32 |
|
panwolfram joined #luanti-dev |
| 23:05 |
|
Eragon joined #luanti-dev |
