| Time |
Nick |
Message |
| 02:31 |
|
vev joined #luanti-dev |
| 03:53 |
|
mrcheese joined #luanti-dev |
| 04:46 |
|
aliasstilltaken joined #luanti-dev |
| 05:00 |
|
MTDiscord joined #luanti-dev |
| 06:06 |
|
vev joined #luanti-dev |
| 08:11 |
|
user333_ joined #luanti-dev |
| 11:56 |
|
whylay joined #luanti-dev |
| 14:50 |
|
mrcheese joined #luanti-dev |
| 16:37 |
sfan5 |
merging #16845, #16823, #16889 in 15m or so |
| 16:37 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16845 -- Fix positive borderwidths box style not working by Wuzzy2 |
| 16:37 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16823 -- Formspec: Fix crash on exit with open settings menu by SmallJoker |
| 16:37 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16889 -- [no squash] Some irrlicht cleanups by sfan5 |
| 16:39 |
Krock |
since we're at it, I'll go ahead merging #16800 and #16823 in 15 minutes |
| 16:39 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16800 -- Network: Unify backwards compatibility checks by SmallJoker |
| 16:39 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16823 -- Formspec: Fix crash on exit with open settings menu by SmallJoker |
| 16:55 |
Krock |
Oh oops. I did not actually realize how quickly after each other we announced that :3 |
| 18:36 |
|
Desour joined #luanti-dev |
| 19:01 |
MTDiscord |
<luatic> opened an issue for the array texture rendering bugs: #16896 |
| 19:01 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16896 -- Severe rendering regression when array textures are used |
| 19:03 |
sfan5 |
so can you reproduce it? |
| 19:08 |
MTDiscord |
<luatic> so far, no |
| 19:08 |
MTDiscord |
<luatic> maybe i'll be able to on some older phone |
| 19:18 |
|
crazylad joined #luanti-dev |
| 19:24 |
crazylad |
Krock: thanks for the help with #16895. could you just clarify what you meant in that review comment on the previous PR? I think I understand, but I'm not sure. while testing the behavior of the scrollbar buttons, it seems to work fine |
| 19:24 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16895 -- Formspec: Make scrollbars scroll while holding down arrow buttons by CrazyladMT |
| 19:33 |
Krock |
crazylad: I think you can answer that question by yourself by increasing the initial time delay and setting the other delay to 1 ms or so. You'll see how only one of the two is used. |
| 19:43 |
Krock |
at this point I would probably just use one delay and KISS. |
| 20:01 |
crazylad |
hmm I see now |
| 20:48 |
Krock |
crazylad: spontaneous idea - in case you're stuck: https://pastebin.com/raw/AfyqjaWS (warning: untested code) |
| 20:49 |
Krock |
with that logic you could also get rid of "m_arrow_down" |
| 20:53 |
crazylad |
"* (up_pressed ? -1 : 1)" why didn't I think of that lol |
| 20:54 |
Krock |
(down_pressed * 2 - 1) works too but might be less intuitive |
| 21:03 |
crazylad |
yea I see the problem with my current proposal now - repeat_delay was actually never being used. |
| 21:06 |
crazylad |
your fix does indeed fix it. however now that repeat_delay works now, it's way too fast lol. not multiplying small_step by 2 anymore and changing repeat_delay to 150 seems reasonable |
| 21:31 |
|
mrcheese joined #luanti-dev |
| 21:32 |
crazylad |
Krock: it seems this works too: https://pastebin.com/raw/FWYNsSV1 |
| 21:32 |
crazylad |
got rid of m_arrow_down |
| 23:34 |
|
panwolfram joined #luanti-dev |
