| Time |
Nick |
Message |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 07:15 |
|
YuGiOhJCJ joined #luanti-dev |
| 14:11 |
|
pgimeno_ joined #luanti-dev |
| 14:57 |
|
Guest56 joined #luanti-dev |
| 15:28 |
|
crazylad joined #luanti-dev |
| 16:48 |
|
jstein joined #luanti-dev |
| 17:28 |
sfan5 |
meeting is in 30m right? |
| 18:03 |
sfan5 |
? |
| 18:10 |
sfan5 |
answer: yes, it is 18:10 UTC right now |
| 18:10 |
MTDiscord |
<jordan4ibanez> Yes |
| 18:10 |
sfan5 |
ping @rubenwardy |
| 18:11 |
rubenwardy |
hello |
| 18:11 |
sfan5 |
ok great, here are the meeting points: https://docs.luanti.org/for-engine-devs/meetings/#2026-04-28 |
| 18:11 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/2026 -- Fix endian.h include for FreeBSD by AMDmi3 |
| 18:12 |
sfan5 |
Q1: should we enter feature freeze now? and release in 2 weeks? |
| 18:13 |
sfan5 |
or rather 15th may if we shorten it a bit |
| 18:13 |
sfan5 |
my vote: yes |
| 18:13 |
rubenwardy |
yes |
| 18:14 |
sfan5 |
ok so 15th may it is |
| 18:14 |
sfan5 |
Q2: RC build? |
| 18:14 |
sfan5 |
I can do that |
| 18:15 |
rubenwardy |
sounds good |
| 18:15 |
sfan5 |
ok, Q3: "Decide which PRs to include in 5.16.0, in particular" |
| 18:15 |
sfan5 |
#17095 |
| 18:15 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17095 -- Implement `core.get_active_blocks`, `core.get_loaded_blocks` and `core.get_loadable_blocks` APIs by kromka-chleba |
| 18:15 |
|
mrcheese joined #luanti-dev |
| 18:15 |
sfan5 |
my opinion: these APIs are useful, not much can go wrong -> yes |
| 18:16 |
|
Desour joined #luanti-dev |
| 18:17 |
rubenwardy |
I think whatever can make it in before the feature freeze cutoff |
| 18:19 |
sfan5 |
well next would be #16971 and I have no idea about its status |
| 18:19 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16971 -- Fix players and entities jolting upwards on the edge of nodes by jordan4ibanez |
| 18:19 |
MTDiscord |
<luatic> as far as i'm concerned this thing is fine, but krock doesn't seem to have gotten a second chance to look at it yet |
| 18:20 |
sfan5 |
referring to 17095 or 16971? |
| 18:20 |
MTDiscord |
<luatic> the latter |
| 18:21 |
MTDiscord |
<luatic> i don't think there's anything important that needs to be done on #16971, krock had a comment on an implementation detail, but it turned out that trying to implement this comment would make the implementation much more awkward. |
| 18:21 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16971 -- Fix players and entities jolting upwards on the edge of nodes by jordan4ibanez |
| 18:21 |
sfan5 |
get it in for release then? |
| 18:21 |
MTDiscord |
<luatic> i would go for that, yes |
| 18:22 |
sfan5 |
i'll put both in the milestone then |
| 18:22 |
sfan5 |
#17101 recently received its approval, any thoughts on that? |
| 18:22 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17101 -- add: overlay_tiles as targets for texturepacks and documention by DiogoAlves06 |
| 18:22 |
sfan5 |
mine: sounds fine if it works |
| 18:23 |
MTDiscord |
<luatic> it does |
| 18:24 |
sfan5 |
ok into the milestone it goes |
| 18:24 |
sfan5 |
next |
| 18:25 |
sfan5 |
Q4: "what do we do about Severe rendering regression when array textures are used? apply the hotfix for another release?" |
| 18:25 |
sfan5 |
#16896 |
| 18:25 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16896 -- Severe rendering regression when array textures are used |
| 18:26 |
MTDiscord |
<luatic> i don't have a better alternative, so yes i guess |
| 18:29 |
Desour |
Remove the hotfix in the RC, to get test responses? |
| 18:29 |
Desour |
and readd it afterwards on release |
| 18:31 |
sfan5 |
we can do that |
| 18:31 |
Krock |
Checking in! I Someone contacted me about a render capture. Unfortunately the time zones are quite apart, thus yet nothing at hand. |
| 18:32 |
Krock |
yes, removing it for RC seems totally fine |
| 18:32 |
MTDiscord |
<luatic> oh hey Krock, if you have a minute, could you take a peek at #16971 and see whether there's anything blocking it? |
| 18:32 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16971 -- Fix players and entities jolting upwards on the edge of nodes by jordan4ibanez |
| 18:33 |
Krock |
reading te backlog |
| 18:33 |
MTDiscord |
<luatic> on your last review you had a refactoring suggestion, but those turned out to be unviable (see the PR for details) |
| 18:33 |
MTDiscord |
<luatic> s/those/that |
| 18:34 |
Krock |
Just provided a follow-up on that https://github.com/luanti-org/luanti/pull/16971#discussion_r3156393053 |
| 18:35 |
Krock |
TL;DR fine, go with the PR as-is. |
| 18:35 |
Krock |
"new_step_up"... and the next logical addition in this regard would be "new_new_step_up". Will review. |
| 18:37 |
MTDiscord |
<luatic> i mean it's no big deal to rename to "step_up_mode" or similar. "new_step_up = 'legacy', ..." does indeed read a bit silly ;) |
| 18:38 |
sfan5 |
if it's about the naming I'd say it's likely that before we get a new_new_step_up the physics end up somehow moved into Lua/mod control |
| 18:40 |
Krock |
perhaps. |
| 18:42 |
sfan5 |
anyway I think it's best if we merge the PRs now so the RC build can be made? |
| 18:44 |
Krock |
I do not think that the step up feature is critical. Merge the others first. |
| 18:45 |
MTDiscord |
<luatic> imma go ahead and merge #17114 |
| 18:45 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17114 -- [manual merge] Use standard shading for inventory rendering by appgurueu |
| 18:45 |
MTDiscord |
<luatic> done |
| 18:46 |
sfan5 |
it's not critical but I would want people to discover any bugs |
| 18:46 |
sfan5 |
unless you say you trust the code since it's not enabled by default |
| 18:47 |
MTDiscord |
<luatic> i can do the rename right now |
| 18:50 |
sfan5 |
oh also |
| 18:50 |
sfan5 |
do we want to keep #17100 in the milestone? it will be annoying to fix and it's not really critical IMO |
| 18:50 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17100 -- Crack overlay not visible on transparent pixels (some drawtypes) |
| 18:50 |
sfan5 |
merging #17095, #17101 in 5m |
| 18:50 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17095 -- Implement `core.get_active_blocks`, `core.get_loaded_blocks` and `core.get_loadable_blocks` APIs by kromka-chleba |
| 18:50 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17101 -- add: overlay_tiles as targets for texturepacks and documention by DiogoAlves06 |
| 18:51 |
Krock |
move to 5.17.0 it's not great but not high priority either |
| 18:54 |
sfan5 |
right |
| 18:54 |
sfan5 |
another one: I made a mistake earlier, do we want to release on 8th may (1.5wk) or 15th may (2.5wk)? |
| 18:55 |
MTDiscord |
<luatic> i say 3.14 |
| 18:56 |
sfan5 |
hm? |
| 18:56 |
MTDiscord |
<luatic> nevermind i can't count months |
| 18:57 |
Krock |
PI day is over |
| 18:57 |
MTDiscord |
<luatic> somehow may and march are the same in my head |
| 18:57 |
sfan5 |
I would tend towards 8th may. we don't need the extra to to solve issues. |
| 18:57 |
Krock |
there shouldn't be too many new features so 8th may |
| 18:58 |
sfan5 |
the extra time* |
| 18:59 |
sfan5 |
ok I think we have everything. |
| 19:04 |
MTDiscord |
<luatic> ok did the rename on #16971, compiled and retested briefly to be sure |
| 19:04 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16971 -- Fix players and entities jolting upwards on the edge of nodes by jordan4ibanez |
| 19:05 |
MTDiscord |
<luatic> merging it now |
| 19:08 |
Krock |
@luatic Thanks. Looks good. |
| 19:13 |
MTDiscord |
<luatic> off to dinner |
| 19:24 |
sfan5 |
will prepare RC build now |
| 19:29 |
Krock |
added the changelog to my todo list. as usual. |
| 19:29 |
Krock |
just pick the builds from the master branch. we didn't do any special tagging before |
| 19:30 |
sfan5 |
oh ok |
| 19:30 |
Krock |
example https://forum.luanti.org/viewtopic.php?t=32266 |
| 19:30 |
Krock |
https://github.com/luanti-org/luanti/releases/tag/5.15.0-rc1 |
| 19:31 |
Krock |
(only renamed the archive, kept the -dev-hash notation) |
| 19:35 |
Krock |
!tell SFENCE Would you please be so nice to provide a build for 5.16.0-rc1 (pre-release on GitHub, soon (TM))? Thank you! |
| 19:35 |
Krock |
~tell SFENCE Would you please be so nice to provide a build for 5.16.0-rc1 (pre-release on GitHub, soon (TM))? Thank you! |
| 19:35 |
ShadowBot |
Krock: OK. |
| 20:06 |
MTDiscord |
<wsor4035> @sfence |
| 20:13 |
sfan5 |
https://github.com/luanti-org/luanti/releases/tag/5.16.0-rc1 |
| 20:14 |
Krock |
thanks |
| 20:14 |
sfan5 |
would you mind creating the forum topic? |
| 20:14 |
Krock |
on it. copypaste time |
| 20:21 |
Krock |
https://forum.luanti.org/viewtopic.php?t=32500 |
| 20:24 |
Krock |
edited to add a reference to #16896 |
| 20:24 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16896 -- Severe rendering regression when array textures are used |
| 20:25 |
Krock |
feel free to adjust the wording if needed. I'll be off to today. |
| 22:34 |
|
panwolfram joined #luanti-dev |
