| Time |
Nick |
Message |
| 00:05 |
|
YuGiOhJCJ joined #luanti-dev |
| 03:36 |
|
book` joined #luanti-dev |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 09:29 |
sfan5 |
#17161 so I also have myself to blame here because literally just joining my test world once would have revealed the bug |
| 09:29 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17161 -- Flowing liquids do not render correctly |
| 09:31 |
sfan5 |
however I did apparently test the PR previously 🤔 |
| 09:31 |
sfan5 |
in hindsight it would have been better to leave it for next release, because nothing breaks if lua_next isn't fixed |
| 10:01 |
sfan5 |
here's a branch we could publish as 5.16.1 https://github.com/luanti-org/luanti/commits/ci |
| 10:10 |
sfan5 |
we should have a rule that refactor PRs are not considered bug fixes and won't be merged during freeze |
| 11:05 |
jonadab |
Refactors definitely should not be merged during a freeze. |
| 11:05 |
jonadab |
Well, not onto the frozen branch. |
| 12:04 |
rubenwardy |
this is already the rule? |
| 12:05 |
sfan5 |
then we should follow it |
| 12:05 |
sfan5 |
(where is it written down even) |
| 12:11 |
rubenwardy |
okay this doesn't seem to be written down, per se |
| 12:11 |
rubenwardy |
:D |
| 12:23 |
|
turtleman joined #luanti-dev |
| 12:53 |
MTDiscord |
<luatic> sfan5: yes it would've been better to delay it to after 5.16.0, i should've written this. part of the reason was that i was too optimistic about it not introducing regressions. i had carefully reviewed the final code myself (and tested some of the larger changes like crafting), but it appears i missed this bug. |
| 12:53 |
MTDiscord |
<luatic> anyways pushing a fix in 5m, see #17161 |
| 12:53 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17161 -- Flowing liquids do not render correctly |
| 13:11 |
sfan5 |
having rendering regression tests would be useful but I can't be bothered |
| 13:12 |
sfan5 |
devtest -> fixed test scene & player position/lookdir -> take screenshot -> compare with known good |
| 14:51 |
Krock |
Sneaking in to provide the unhelpful remark that "I said it." https://irc.luanti.org/luanti-dev/2026-05-08#i_6326224 |
| 14:52 |
Krock |
We might as well wait until tomorrow in case there's more bugs |
| 14:56 |
Krock |
sfan5: bonus benefit for such scene: automatic performance detection |
| 17:33 |
rubenwardy |
I'm guessing that I should wait for 5.16.1 to release android |
| 17:56 |
MTDiscord |
<luatic> yes please |
| 19:12 |
|
swags joined #luanti-dev |
| 19:13 |
|
swags joined #luanti-dev |
| 22:32 |
|
panwolfram joined #luanti-dev |
