| Time |
Nick |
Message |
| 03:47 |
|
YuGiOhJCJ joined #luanti-dev |
| 03:55 |
|
YuGiOhJCJ joined #luanti-dev |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 04:02 |
|
YuGiOhJCJ joined #luanti-dev |
| 05:35 |
|
sofar joined #luanti-dev |
| 05:50 |
|
sofar joined #luanti-dev |
| 05:52 |
|
sofar joined #luanti-dev |
| 05:57 |
|
sofar joined #luanti-dev |
| 05:57 |
|
sofar joined #luanti-dev |
| 06:36 |
|
ivanbu joined #luanti-dev |
| 08:22 |
|
Warr1024 joined #luanti-dev |
| 08:47 |
|
Warr1024 joined #luanti-dev |
| 09:08 |
|
[MatrxMT] joined #luanti-dev |
| 09:18 |
sfan5 |
so 5.16.1 today? |
| 09:26 |
Krock |
yes |
| 09:31 |
Krock |
sfan5: changelog https://pastebin.com/raw/YqcZHnxr |
| 09:32 |
Krock |
I could simply update the 5.16.0 forum post to 5.16.1 since that's still quite new |
| 09:36 |
sfan5 |
yeah we could |
| 09:37 |
sfan5 |
question is: do we cherry-pick the fix or take this branch with the revert https://github.com/luanti-org/luanti/commits/ci/ ? |
| 09:40 |
Krock |
honestly I'd prefer the revert |
| 09:41 |
Krock |
such that the rest of the changes can be tested well throughout 6.17.0-dev |
| 09:44 |
sfan5 |
agreed |
| 09:47 |
sfan5 |
release now or later? |
| 09:58 |
Krock |
Feel free to do so. I'll be away for lunch. |
| 10:09 |
sfan5 |
I'll prepare the commit at least |
| 10:58 |
Krock |
sfan5: would you like me to test the build on Windows? |
| 11:01 |
sfan5 |
sure |
| 11:09 |
Krock |
singleplayer works, flowing liquids work, shaders work, crafting works. LGTM |
| 11:09 |
Krock |
(tested NSIS and the 32-bit build) |
| 11:22 |
Krock |
for whatever reason, the unittests failed on VS x64: https://github.com/luanti-org/luanti/actions/runs/25626039436/job/75221257017#step:6:604 |
| 11:22 |
sfan5 |
they always do |
| 11:22 |
Krock |
oh. I did not realize |
| 16:02 |
Krock |
sfan5: I'll go ahead and push the ci branch to stable-5 - any objections? |
| 16:03 |
Krock |
plus all the bells and whistles around. I'll only then need someone to push the changelog (see logs) to the dev wiki |
| 16:04 |
MTDiscord |
<luatic> fine with revert for 5.16.1 👍 |
| 16:11 |
Krock |
alright. thanks. |
| 16:30 |
Krock |
push push |
| 16:35 |
Krock |
would someone please be so nice to push https://pastebin.com/raw/YqcZHnxr to docs.luanti.org ? |
| 16:35 |
MTDiscord |
<rollerozxa> yes I can do that real quick |
| 16:37 |
MTDiscord |
<rollerozxa> done |
| 16:37 |
rubenwardy |
huh, engine doesn't have write to docs.luanti.org? |
| 16:38 |
rubenwardy |
added |
| 16:38 |
Krock |
now I've got access. Thanks. |
| 16:39 |
Krock |
feel free to do the Android builds now, and update ContentDB |
| 16:39 |
Krock |
hopefully this one won't need a .2 release |
| 16:55 |
|
rubenwardy joined #luanti-dev |
| 17:20 |
sfan5 |
did we release? |
| 17:21 |
sfan5 |
the tag is wrong btw, it should not be on the stable-5 branch |
| 17:21 |
sfan5 |
i have it locally so I'll just force-push the tag |
| 17:24 |
Krock |
oh? I thought the tag is supposed to be on stable-5 for backports |
| 17:25 |
Krock |
since there's no master equivalent |
| 17:43 |
sfan5 |
the the tag has linear history with the previous tag. it gets merged into stable-5 and then that has the complicated history. |
| 17:43 |
sfan5 |
(w/ previous tag in case of patch releases, w/ master for major/minor releases) |
| 18:12 |
Krock |
That makes sense - makes it easier to look up the changes |
| 18:13 |
Krock |
lesson learnt. The strict "merge commit into stable-5" makes totally sense then |
| 18:29 |
|
crazylad joined #luanti-dev |
| 18:29 |
|
crazylad joined #luanti-dev |
| 18:52 |
|
MTDiscord joined #luanti-dev |
| 21:18 |
|
jstein joined #luanti-dev |
| 22:32 |
|
panwolfram joined #luanti-dev |
| 22:52 |
MTDiscord |
<luatic> i suggest we adopt a guideline similar to https://abseil.io/tips/88 for C++ initialization style choices |
| 23:19 |
|
YuGiOhJCJ joined #luanti-dev |
| 23:20 |
MTDiscord |
<luatic> gah launchpad is behaving strangely. builds are failing (complaining about 5.16.1 tag not being found) even though i've synced the repo (and pulled to verify). |
| 23:26 |
MTDiscord |
<josiah_wi> I think the Windows CI on #17166 needs to be rerun. It seems to have failed spuriously due to vcpkg connectivity issues. |
| 23:26 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17166 -- MTP Server: Acquire info mutex to set peer ID by JosiahWI |
