| Time |
Nick |
Message |
| 00:41 |
|
MTDiscord1 joined #luanti-dev |
| 01:02 |
|
mrcheese joined #luanti-dev |
| 04:00 |
|
MTDiscord joined #luanti-dev |
| 07:00 |
|
Panquesito7_ joined #luanti-dev |
| 07:01 |
|
Panquesito7_ joined #luanti-dev |
| 07:02 |
|
Panquesito7 joined #luanti-dev |
| 15:10 |
sfan5 |
I will now update weblate and include the string updates from #15417 |
| 15:10 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/15417 -- Visual Effects Vol. 2 by GefullteTaubenbrust2 |
| 15:11 |
sfan5 |
in the worst case (PR not merged) we'll have two untranslated settings |
| 15:38 |
sfan5 |
https://github.com/luanti-org/luanti/commits/ci/ |
| 15:46 |
sfan5 |
for some reason I can't get the client to use the 'my' language to test it, but if I copy-paste text to a box it's invisible so I'll add it to the blacklist |
| 15:47 |
sfan5 |
pushing once CI finishes |
| 16:26 |
|
Panquesito7 joined #luanti-dev |
| 16:40 |
|
Panquesito7 joined #luanti-dev |
| 16:55 |
|
crazylad joined #luanti-dev |
| 17:02 |
Krock |
sfan5: FYI the CI finished |
| 17:02 |
Krock |
and about https://github.com/luanti-org/luanti/pull/17425#discussion_r3750276589 - this sscanf does pass the underflow and sign checks |
| 17:18 |
sfan5 |
weblate updated now |
| 17:22 |
sfan5 |
I just don't like sscanf in general |
| 17:30 |
Krock |
okay |
| 18:43 |
Krock |
Might anyone who voted for "Yes" on the Visuals Vol 2 have a few minutes to spare to test the features in-world? From what I can see, it has mostly went through static analysis only. |
| 18:47 |
[MatrxMT] |
<Zughy> Busy, can't, sorry |
| 18:54 |
MTDiscord |
<wsor4035> i will tonight |
| 18:55 |
Krock |
will push trivial patch https://pastebin.com/raw/T5D427CS in 20 minutes unless there are objections |
| 18:55 |
Krock |
context: https://forum.luanti.org/viewtopic.php?p=452232#p452232 |
| 18:56 |
sfan5 |
lgtm |
| 19:14 |
Krock |
puuuushed |
| 20:39 |
|
red-001 joined #luanti-dev |
| 20:40 |
red-001 |
when is the next released planned for? |
| 21:43 |
|
rubenwardy joined #luanti-dev |
| 21:53 |
|
crazylad joined #luanti-dev |
| 21:55 |
crazylad |
red-001: I think in two weeks |
| 21:56 |
red-001 |
ah |
| 21:57 |
red-001 |
so enforcing built-in hashes that's not in this change window? |
| 22:06 |
sfan5 |
https://github.com/luanti-org/luanti/milestone/33 |
| 22:09 |
crazylad |
Krock: so... maybe a dumb question, but were you suggesting that #17305 could be merged in 5.17.0 too, despite the feature freeze? like, if you guys are merging that visual effects PR during a feature freeze, then couldn't this one make it in too? :P |
| 22:09 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17305 -- Add `listimages[]` element to allow styling inventory slots with textures by CrazyladMT |
| 22:10 |
crazylad |
it seems kinda low risk I think and it doesn't add any new strings - otherwise the formspec version would have to be again bumped for 5.18.0 (which isn't bad I guess) so modders can check support for `listimages[]` |
| 22:19 |
MTDiscord |
<jordan4ibanez> Please merge it please I beg of you |
| 22:19 |
crazylad |
lol |
| 22:24 |
crazylad |
bbl |
| 22:33 |
|
panwolfram joined #luanti-dev |
| 23:45 |
MTDiscord |
<wsor4035> krock: from the pr example core.get_player_by_name("singleplayer"):set_lighting({ artificial_light = { r = 140, g = 120, b = 100 }, cdl = { offset = { x = 1, y = 1, z = 1 }, slope = { x = -1, y = -1, z = -1 }, power = { x = 2, y = 2, z = 2 } }, vignette = { dark = 0, bright = 2, power = 0.5 }, volumetric_light = { beta_r0 = { x = 2, y = 1, z = 0.5 } }, foliage_translucency = 4.0, specular_intensity = 4.0 }) |
| 23:45 |
MTDiscord |
<wsor4035> is the example supposed to look like this? |
| 23:45 |
MTDiscord |
<wsor4035> https://cdn.discordapp.com/attachments/747163566800633906/1536520903964368956/image.png?ex=6a7bb41a&is=6a7a629a&hm=814fbd7f1040ad606ca997f115cd3032e0768adfea1e90272446bc8080b80acf& |
