| Time |
Nick |
Message |
| 00:38 |
|
ndorik-zenith joined #luanti-dev |
| 01:04 |
|
ndorik-zenith joined #luanti-dev |
| 03:03 |
|
ndorik-zenith joined #luanti-dev |
| 03:34 |
|
ndorik-zenith joined #luanti-dev |
| 03:37 |
|
ndorik-zenith_ joined #luanti-dev |
| 04:01 |
|
mrcheese joined #luanti-dev |
| 04:10 |
|
ndorik-zenith joined #luanti-dev |
| 04:51 |
|
Panquesito7_ joined #luanti-dev |
| 05:00 |
|
MTDiscord joined #luanti-dev |
| 05:27 |
|
ndorik-zenith joined #luanti-dev |
| 08:14 |
|
sugarbeet joined #luanti-dev |
| 09:10 |
|
ndorik-zenith joined #luanti-dev |
| 09:29 |
|
ndorik-zenith joined #luanti-dev |
| 09:31 |
|
ndorik-zenith_ joined #luanti-dev |
| 09:40 |
|
ndorik-zenith joined #luanti-dev |
| 09:47 |
|
ndorik-zenith joined #luanti-dev |
| 10:56 |
|
SpaceManiac joined #luanti-dev |
| 11:11 |
|
ndorik-zenith joined #luanti-dev |
| 11:12 |
|
ndorik-zenith_ joined #luanti-dev |
| 11:34 |
|
ndorik-zenith joined #luanti-dev |
| 12:53 |
|
ndorik-zenith joined #luanti-dev |
| 13:47 |
|
turtleman joined #luanti-dev |
| 14:09 |
|
Panquesito7 joined #luanti-dev |
| 14:36 |
|
ndorik-zenith joined #luanti-dev |
| 15:02 |
|
ndorik-zenith joined #luanti-dev |
| 17:31 |
sfan5 |
opinions needed on #17761 |
| 17:31 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17761 -- Extract common texture definition logic by tygyh |
| 17:43 |
Krock |
I don't see how this improves anything |
| 17:43 |
Krock |
ah. commenting on GitHub instead. |
| 18:42 |
|
ndorik-zenith joined #luanti-dev |
| 18:52 |
|
ndorik-zenith joined #luanti-dev |
| 19:01 |
sfan5 |
do you think it's worth it working on such tiny code changes? |
| 19:13 |
Krock |
I suppose it's worth having a look at it for each case. In this particular one I believe that passing the constructed object down would tidy the code a bit |
| 19:14 |
Krock |
though I also made this PR as a statement, which turned out to be controversial. #17594 |
| 19:14 |
ShadowBot |
Krock: Error: That URL raised <Connection timed out.> |
| 19:14 |
Krock |
thanks ShadowBot |
| 19:20 |
|
swift110-mobile_ joined #luanti-dev |
| 19:45 |
sfan5 |
merging #17760, #17754, #17752, #17450 in 10m |
| 19:45 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17760 -- [no squash] Animation timer + httpfetch improvements by sfan5 |
| 19:45 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17754 -- Translate Swedish builtin command help by yeager |
| 19:45 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17752 -- [no squash] Make item image animation work for dropped item entities and refactoring by cx384 |
| 19:45 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17450 -- Update builtin help formspec with search by ZenonSeth |
| 20:03 |
sfan5 |
done |
| 21:20 |
sfan5 |
Krock: now the PR has a completely different approach again and the CI is once again red |
| 21:20 |
sfan5 |
I get the impression the submitter is just trying random stuff and then waiting for the CI and our reviews to tell them what's wrong |
| 21:20 |
sfan5 |
this is in no way productive |
| 21:21 |
sfan5 |
(this isn't some subtle edge case. if they compile-tested the code one they would have noticed that it doesn't work) |
| 21:21 |
sfan5 |
once* |
| 21:26 |
sfan5 |
merging #17465 in 10m (forgot that earlier) |
| 21:26 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/17465 -- [no squash] Formspec: Refactor HyperTip handling by SmallJoker |
| 21:37 |
sfan5 |
uh I didn't see those two extra commits |
| 23:34 |
|
panwolfram joined #luanti-dev |
| 23:45 |
|
YuGiOhJCJ joined #luanti-dev |