| Time |
Nick |
Message |
| 00:01 |
|
sys4 joined #luanti |
| 00:44 |
|
crazylad joined #luanti |
| 01:05 |
|
Eragon joined #luanti |
| 01:20 |
|
Haven0320 joined #luanti |
| 01:51 |
|
lemonzest joined #luanti |
| 01:52 |
|
mrcheese joined #luanti |
| 01:55 |
repetitivestrain |
Krock: https://paste.centos.org/view/303d820e |
| 02:08 |
|
SFENCE joined #luanti |
| 02:27 |
|
SFENCE joined #luanti |
| 02:32 |
|
Verticen joined #luanti |
| 02:36 |
|
aliasreadytaken joined #luanti |
| 02:49 |
|
SFENCE joined #luanti |
| 02:50 |
[MatrxMT] |
<Blockhead256> https://github.com/luanti-org/luanti/issues/10770 |
| 02:50 |
[MatrxMT] |
<Blockhead256> https://forum.luanti.org/viewtopic.php?p=406391#p406391 |
| 03:24 |
|
SFENCE joined #luanti |
| 03:32 |
sofar |
FWIW I've shut down the PRMS (Public Remote Media Server) that I was operating. It's been 6 months since the client side API change made it no longer feasible. It was fun while it lasted. I'd love to think about a future solution to the remote media problem but right now there isn't any reason to keep it running (it's almost entirely unused now due to said API changes). |
| 03:56 |
|
FileX joined #luanti |
| 04:00 |
|
MTDiscord joined #luanti |
| 04:22 |
|
mrcheese joined #luanti |
| 04:53 |
|
SFENCE joined #luanti |
| 05:01 |
|
SFENCE joined #luanti |
| 06:00 |
repetitivestrain |
luantiserver is crashing with /export/home/jw/EXPUNGED/minetest/src/server.cpp:1426: void Server::Send(NetworkPacket*): A fatal error occurred: Server::Send() missing |
| 06:01 |
repetitivestrain |
since i updated to a version of the engine with particle packet batching |
| 06:04 |
|
jaca122 joined #luanti |
| 06:14 |
|
YuGiOhJCJ joined #luanti |
| 06:43 |
|
YuGiOhJCJ joined #luanti |
| 06:52 |
|
identity joined #luanti |
| 07:26 |
|
Talkless joined #luanti |
| 08:22 |
|
Warr1024 joined #luanti |
| 08:47 |
|
Warr1024 joined #luanti |
| 08:49 |
sfan5 |
any specific repro steps? |
| 08:56 |
repetitivestrain |
sfan5: i'm afraid not, as it just struck spontaneously on the first occasion a player left my server after updating to a version with the particle batching commit |
| 09:06 |
Krock |
https://github.com/luanti-org/luanti/blob/5.14.0-rc1/src/server.cpp#L1426 |
| 09:07 |
Krock |
https://github.com/luanti-org/luanti/blob/5.14.0-rc1/src/server.cpp#L1652-L1655 |
| 09:09 |
Krock |
the PlayerSAO check on L1621 should already ensure that the Peer ID is ready if the player is still joining (e.g. loading media) |
| 09:10 |
repetitivestrain |
the crash occurred as a player was leaving, if it's of any assistance |
| 09:10 |
repetitivestrain |
Krock: btw, in reply to yesterday's question: https://paste.centos.org/view/303d820e |
| 09:11 |
Krock |
repetitivestrain: thanks. I'll open a PR for that. |
| 09:11 |
repetitivestrain |
Much appreciated |
| 09:13 |
Krock |
PlayerSAO::disconnected() should probably unlink itself from RemotePlayer and be deleted afterwards |
| 09:18 |
Krock |
yeah. that should fix it. the SAO is cleaned up according to m_known_by_count |
| 09:21 |
repetitivestrain |
https://paste.debian.net/1398481/ |
| 09:21 |
repetitivestrain |
stack trace, if it helps |
| 09:35 |
|
mrkubax10 joined #luanti |
| 09:56 |
Krock |
repetitivestrain: https://pastebin.com/raw/w1gbkhUn |
| 09:57 |
Krock |
unfortunately, the code is quite dependent on PlayerSAO while RemotePlayer already had PEER_ID_INVALID, thus a future-proof solution might have to be done later |
| 09:57 |
Krock |
s/ had / has / |
| 10:50 |
|
turtleman joined #luanti |
| 10:51 |
|
SFENCE joined #luanti |
| 11:11 |
Krock |
repetitivestrain: I adjusted the indent level of your patch and proposed it in #16524. Would you please be so nice to check whether the diff above fixes your "error on leave" issue? |
| 11:11 |
ShadowBot |
https://github.com/luanti-org/luanti/issues/16524 -- Mapgen: Correct border block criteria by SmallJoker |
| 11:14 |
Krock |
(GitHub still does not show the correct authorship in the first tab, but works properly in the "Commits" tab) |
| 11:15 |
|
ireallyhateirc joined #luanti |
| 11:27 |
|
mrkubax10 joined #luanti |
| 11:36 |
|
stg-developer joined #luanti |
| 11:43 |
|
PoochInquisitor joined #luanti |
| 13:49 |
|
mrcheese joined #luanti |
| 14:02 |
|
turtleman joined #luanti |
| 14:31 |
|
mrcheese joined #luanti |
| 14:48 |
|
PoochInquisitor joined #luanti |
| 15:54 |
|
mrkubax10 joined #luanti |
| 16:23 |
|
erle joined #luanti |
| 16:34 |
|
identity joined #luanti |
| 16:57 |
user2_ |
almost 90 PRs open |
| 16:58 |
Krock |
user2_: get it to 100 |
| 16:58 |
Krock |
you can do it. I have faith in you. |
| 16:58 |
Krock |
JUST DO IT |
| 16:58 |
user2_ |
i cant... i need a github account :D: |
| 16:58 |
Krock |
open a PR on CodeBerg or so |
| 16:59 |
user2_ |
i probably need an account there too |
| 16:59 |
Krock |
yes, collaboration generally requires accounts. As for IRC... optional. |
| 17:00 |
user2_ |
i'm still not sure if mine is registered properly... |
| 17:01 |
identity |
user2_: you are not identified |
| 17:01 |
[MatrxMT] |
<birdlover32767> i mean it's clear enough by the messages imo |
| 17:02 |
user2_ |
afaik, it means anyone could take my account |
| 17:02 |
Krock |
> Registered : Mar 24 11:31:46 2024 +0000 (1y 26w 6d ago) |
| 17:02 |
user2_ |
uh yeah that wasn't me... |
| 17:03 |
user2_ |
;-; |
| 17:04 |
user2_ |
i'l have to find a user(number)_ account that isn't taken |
| 17:05 |
Krock |
rename to username_taken 8) |
| 17:05 |
Krock |
use 8 asterisks as you password so that you cannot get hacked |
| 17:05 |
user2_ |
that's all that passwords are anyway, just asterisks |
| 17:06 |
user2_ |
totally |
| 17:06 |
Krock |
hunter2 |
| 17:06 |
user2_ |
ima just keep trying user(number)_ accounts |
| 17:07 |
|
user2_ left #luanti |
| 17:13 |
|
user2_ joined #luanti |
| 17:13 |
user2_ |
now... is this one taken... |
| 17:13 |
user2_ |
wait- |
| 17:14 |
user2_ |
i didnt even switch it -_- |
| 17:16 |
|
user2_ joined #luanti |
| 17:16 |
user2_ |
did it work now? |
| 17:16 |
user2_ |
... |
| 17:16 |
|
user2_ left #luanti |
| 17:17 |
|
user2_ joined #luanti |
| 17:18 |
|
user2_ left #luanti |
| 17:20 |
|
user2_ joined #luanti |
| 17:21 |
|
user2_ left #luanti |
| 17:21 |
|
user2_ joined #luanti |
| 17:25 |
user2_ |
well uh... i cant figure it out, ig i will just stick with this one ;-; |
| 17:53 |
|
SFENCE joined #luanti |
| 17:56 |
|
SFENCE joined #luanti |
| 18:57 |
|
cryne797 joined #luanti |
| 20:00 |
|
alias joined #luanti |
| 20:16 |
|
SFENCE joined #luanti |
| 20:32 |
|
SFENCE joined #luanti |
| 20:37 |
|
identity joined #luanti |
| 20:54 |
|
SFENCE joined #luanti |
| 21:17 |
|
Haven0320 joined #luanti |
| 21:48 |
|
pgimeno joined #luanti |
| 22:04 |
|
Kimapr_ joined #luanti |
| 22:33 |
|
panwolfram joined #luanti |
| 22:35 |
|
Kimapr_ joined #luanti |
| 22:45 |
|
Kimapr_ joined #luanti |
| 22:49 |
|
seasharp joined #luanti |
| 23:00 |
|
Atreides23 joined #luanti |
| 23:20 |
|
FeXoR joined #luanti |
| 23:50 |
|
Helenah joined #luanti |
