| Time |
Nick |
Message |
| 00:02 |
Fixer |
i will test tom(m)or(r)ow if all goes well |
| 00:03 |
paramat |
ok thanks |
| 00:03 |
Fixer |
too late to test, afk problems |
| 00:03 |
Fixer |
i've compiled already |
| 00:04 |
Fixer |
extreme night, gn |
| 00:23 |
|
Grandolf joined #minetest-dev |
| 00:23 |
|
halt_ joined #minetest-dev |
| 01:05 |
|
Fritigern joined #minetest-dev |
| 01:21 |
|
Miner_48er joined #minetest-dev |
| 01:28 |
|
Puka joined #minetest-dev |
| 01:36 |
|
Fritigern_ joined #minetest-dev |
| 01:40 |
|
kaeza joined #minetest-dev |
| 02:27 |
|
ssieb joined #minetest-dev |
| 03:56 |
|
Lunatrius` joined #minetest-dev |
| 05:03 |
|
nerzhul joined #minetest-dev |
| 05:14 |
|
Hunterz joined #minetest-dev |
| 05:24 |
|
proller__ joined #minetest-dev |
| 06:23 |
nerzhul |
i will push the memleak fix on MeshUpdateQueue cache in 4-5 min. Zeno` <- |
| 06:23 |
Zeno` |
oh you've done it? I was just starting to do it lol |
| 06:23 |
Zeno` |
link? |
| 06:24 |
Zeno` |
(good timing!) |
| 06:24 |
nerzhul |
it's on my workspace now , i just iterate on the MeshUpdateQueue m_cache in the destructor and delete all elements in map |
| 06:24 |
Zeno` |
yeah |
| 06:25 |
Zeno` |
so trivial as I suspected it would be |
| 06:25 |
nerzhul |
https://pastebin.com/XkxzVjVm |
| 06:25 |
nerzhul |
it works as intended, no crash on game leave |
| 06:26 |
nerzhul |
okay for pushing this ? |
| 06:29 |
Zeno` |
yep of course |
| 06:31 |
nerzhul |
pushed |
| 06:33 |
Zeno` |
what did you use to create that diff? |
| 06:33 |
Zeno` |
it looks different than usual |
| 06:33 |
nerzhul |
oh i kept the header, it's exact :p i tell clion to export the patch from the current dev |
| 08:04 |
|
kilbith joined #minetest-dev |
| 08:07 |
Hijiri |
any reviews for #5612? |
| 08:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/5612 -- Allow overriding tool capabilities through itemstack metadata by raymoo |
| 08:33 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:55 |
|
nerzhul joined #minetest-dev |
| 10:05 |
|
jomatv6 joined #minetest-dev |
| 10:10 |
|
jomat joined #minetest-dev |
| 10:11 |
|
Taoki joined #minetest-dev |
| 10:39 |
nerzhul |
oh nice, i didn't know about std::hash in C++11 which is constexpr permitting to do switch cases on strings :D |
| 10:39 |
nerzhul |
https://dev.to/foxtacles/why-c-is-fun-to-me-template-metaprogramming |
| 10:40 |
|
Fixer joined #minetest-dev |
| 11:16 |
|
Raven262 joined #minetest-dev |
| 11:16 |
|
est31 joined #minetest-dev |
| 11:17 |
kilbith |
est31! |
| 11:17 |
|
DI3HARD139 joined #minetest-dev |
| 11:18 |
est31 |
hi |
| 11:18 |
est31 |
I've been too lazy to find a way to turn off the automatic rejoin |
| 11:18 |
est31 |
but as I'm here, whats up with minetest |
| 11:18 |
est31 |
feature freeze on sunday? good luck folks |
| 11:19 |
kilbith |
well, not much |
| 11:19 |
kilbith |
that could interest you: https://github.com/minetest/minetest/commit/071e114ffa9 |
| 11:19 |
est31 |
cool |
| 11:20 |
est31 |
good for private chests |
| 11:20 |
est31 |
or I think they already had an exception of some sort? |
| 11:20 |
* est31 |
can't remember |
| 11:20 |
est31 |
hmm gtg, good luck with the 0.4.16 release! |
| 11:20 |
|
est31 left #minetest-dev |
| 11:23 |
|
lisac joined #minetest-dev |
| 12:18 |
|
RobbieF joined #minetest-dev |
| 12:32 |
kilbith |
the chest staying opened: https://lut.im/kVg0Cg1K05/7fkMQ7riBENBL5fn.png |
| 12:33 |
|
kaeza joined #minetest-dev |
| 12:34 |
|
DS-minetest joined #minetest-dev |
| 13:39 |
|
Darcidride joined #minetest-dev |
| 13:41 |
|
iZacZip joined #minetest-dev |
| 13:46 |
|
Warr1024 joined #minetest-dev |
| 14:41 |
|
rubenwardy joined #minetest-dev |
| 14:48 |
|
RichardTheTurd joined #minetest-dev |
| 14:57 |
Fixer |
!tell kilbith known |
| 14:57 |
ShadowBot |
Fixer: O.K. |
| 14:58 |
|
Player_2 joined #minetest-dev |
| 14:58 |
nerzhul |
!tell Fixer fixed |
| 14:58 |
ShadowBot |
nerzhul: O.K. |
| 15:07 |
|
kilbith joined #minetest-dev |
| 15:21 |
|
nore joined #minetest-dev |
| 15:38 |
|
Fixer joined #minetest-dev |
| 15:41 |
Fixer |
nsfw (also contains mario): https://twitter.com/destructoid/status/864221687666982913 |
| 15:41 |
Fixer |
oops, wrong channel |
| 15:42 |
|
cx384 joined #minetest-dev |
| 15:45 |
|
twoelk joined #minetest-dev |
| 16:04 |
|
Krock joined #minetest-dev |
| 16:04 |
|
Krock joined #minetest-dev |
| 16:15 |
|
octacian joined #minetest-dev |
| 16:17 |
|
paramat joined #minetest-dev |
| 16:28 |
|
celeron55 joined #minetest-dev |
| 16:42 |
twoelk |
might be a stupid question but how do I see the latest changes to a file in github? |
| 16:42 |
VanessaE |
use the "history" link |
| 16:44 |
twoelk |
hm, ok latest state of a pull request might be the more correct wording |
| 16:45 |
twoelk |
I was looking for the current version of #4994 |
| 16:45 |
ShadowBot |
https://github.com/minetest/minetest/issues/4994 -- Clear Inventory Chatcommand (/clearinv) by octacian |
| 16:45 |
VanessaE |
oh for that you can just look at the commit list I suppose |
| 16:45 |
twoelk |
I just see the initial commit |
| 16:45 |
VanessaE |
at the top it says something like "conversation, commits, files changes" |
| 16:46 |
VanessaE |
if you click "commits" you get the full list |
| 16:46 |
VanessaE |
and then from there maybe you can "view" a file and then read the "history" link? |
| 16:46 |
|
Fuchs left #minetest-dev |
| 16:47 |
twoelk |
just the one file :-( |
| 16:47 |
VanessaE |
no history? |
| 16:47 |
twoelk |
one commit |
| 16:48 |
twoelk |
5th jan, but there should be changes after that. I must be missing something obvious |
| 16:54 |
|
nore joined #minetest-dev |
| 16:55 |
paramat |
the date is when the commit was started, not last edited |
| 16:58 |
twoelk |
then I seem to not find where he adds the clearinv priv |
| 17:04 |
paramat |
it doesn't, it uses 'server' priv |
| 17:04 |
paramat |
as we requested |
| 17:04 |
twoelk |
not what he states at the top |
| 17:06 |
twoelk |
I just wanted to check wether it was me simply using github wrong |
| 17:07 |
paramat |
commit message needs updating |
| 17:08 |
paramat |
commented |
| 17:09 |
twoelk |
seen :-) |
| 17:30 |
|
kilbith joined #minetest-dev |
| 18:25 |
paramat |
i might merge #5744 later since it is a simple change to my own mapgen code and well tested, however an approval would be nice if anyone is able or trusts me |
| 18:25 |
ShadowBot |
https://github.com/minetest/minetest/issues/5744 -- Caverns: Remove unnecessary liquid excavation by paramat |
| 18:39 |
|
nerzhul_ joined #minetest-dev |
| 18:43 |
paramat |
5744 is needed for release as it alters cave placement, so this finishes the new cavern feature |
| 18:46 |
|
nerzhul__ joined #minetest-dev |
| 18:59 |
|
rom1504 joined #minetest-dev |
| 18:59 |
|
rubywarden joined #minetest-dev |
| 19:33 |
|
paramat joined #minetest-dev |
| 19:38 |
|
twoelk left #minetest-dev |
| 19:49 |
|
nore joined #minetest-dev |
| 20:10 |
paramat |
#5760 is updated and ready for review (affects single particles only) |
| 20:10 |
ShadowBot |
https://github.com/minetest/minetest/issues/5760 -- Particles: Do not send single particles to distant clients by paramat |
| 20:12 |
|
rubenwardy joined #minetest-dev |
| 20:15 |
|
est31 joined #minetest-dev |
| 20:18 |
paramat |
will merge #5744 in a few mins |
| 20:18 |
ShadowBot |
https://github.com/minetest/minetest/issues/5744 -- Caverns: Remove unnecessary liquid excavation by paramat |
| 20:18 |
|
RobbieF left #minetest-dev |
| 20:18 |
|
rom1504 joined #minetest-dev |
| 20:20 |
paramat |
ShadowNinja are you +1 for #5756 ? |
| 20:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/5756 -- CSM: Document forgotten functions by SmallJoker |
| 20:26 |
paramat |
all your requests are attended to so i will merge that too |
| 20:27 |
paramat |
red-005 ^ ok with that PR? |
| 20:29 |
paramat |
nerzhul too? ^ |
| 20:29 |
red-005 |
5756? |
| 20:29 |
red-005 |
yeah that looks good |
| 20:31 |
|
rubenwardy joined #minetest-dev |
| 20:38 |
nerzhul__ |
i will merge it tomorrow if not already done |
| 20:48 |
paramat |
ok thanks will merge it in a few mins with 5744 |
| 21:01 |
paramat |
merging |
| 21:07 |
paramat |
merged. PRs + issues still < 1000 |
| 21:07 |
paramat |
perhaps a good challenge to keep it that way |
| 21:53 |
|
Taoki joined #minetest-dev |
| 22:14 |
|
hfranqui joined #minetest-dev |
| 22:17 |
hfranqui |
Hello all... quick question, Github noob. |
| 22:17 |
hfranqui |
I want to test a PR that hasn't been merged yet. How do I add it to my master branch of Minetest? |
| 22:25 |
paramat |
instead you could download the authors branch of MT that contains the PR and compile it? |
| 22:26 |
paramat |
it's easier |
| 22:26 |
Fixer |
sofar knows how |
| 22:26 |
Fixer |
i do it differently |
| 22:26 |
Fixer |
i go into PR page |
| 22:27 |
Fixer |
add .diff to its end in URL, save the .diff |
| 22:27 |
paramat |
also it's not a good idea to add a PR to your master branch, that should remain unaltered from official MT |
| 22:27 |
Fixer |
then goto source and patch -p0 < that.diff (iirc) |
| 22:28 |
paramat |
anyway, personally i download another MT and keep it separate, then add the PR to that |
| 22:28 |
paramat |
safer |
| 22:28 |
Fixer |
because you are dev |
| 22:28 |
Fixer |
and have commit access |
| 22:29 |
nore |
hfranqui: what I use it: |
| 22:29 |
nore |
locally, create another git branch |
| 22:29 |
nore |
(git checkout -b [new branch name]) |
| 22:30 |
nore |
download the patch (wget https://github.com/minetest/minetest/pull/<number>.patch) |
| 22:30 |
nore |
and then git am <number>.patch |
| 22:31 |
nore |
(then you can go back to the master branch by just doing git checkout master) |
| 22:39 |
paramat |
no, commit access is not needed for what i do |
| 22:48 |
Fixer |
paramat: yes, but you can do something bad, so you just clone it into other dir |
| 22:50 |
|
halt_ joined #minetest-dev |
| 22:50 |
|
Grandolf joined #minetest-dev |
| 23:21 |
|
proller joined #minetest-dev |
| 23:34 |
|
proller joined #minetest-dev |
| 23:46 |
|
rubenwardy joined #minetest-dev |
| 23:48 |
|
Fixer joined #minetest-dev |
| 23:52 |
|
paramat joined #minetest-dev |
| 23:55 |
|
proller joined #minetest-dev |
