| Time |
Nick |
Message |
| 00:25 |
benrob0329 |
rubenwardy: but semvar |
| 00:33 |
|
bigfoot547 joined #minetest-dev |
| 00:39 |
|
g0d355__ joined #minetest-dev |
| 00:49 |
KaadmY |
benrob0329: Minetest doesn't use anything remotely resembling semver in how it acts |
| 00:53 |
benrob0329 |
KaadmY: well no, thus the point |
| 01:14 |
|
Tmanyo joined #minetest-dev |
| 01:15 |
|
DI3HARD139 joined #minetest-dev |
| 01:23 |
|
paramat joined #minetest-dev |
| 01:26 |
|
CalebDavis joined #minetest-dev |
| 02:05 |
KaadmY |
I think my lighting is PR-ready |
| 02:05 |
KaadmY |
How do you rebase with a fork in a seperate branch? |
| 02:07 |
|
octacian joined #minetest-dev |
| 02:25 |
KaadmY |
Thoughts on https://github.com/minetest/minetest/pull/6165? |
| 02:26 |
|
proller joined #minetest-dev |
| 02:27 |
|
CalebDavis joined #minetest-dev |
| 02:27 |
|
troller joined #minetest-dev |
| 02:36 |
octacian |
#6165 :P |
| 02:36 |
ShadowBot |
https://github.com/minetest/minetest/issues/6165 -- Shading by kaadmy |
| 02:37 |
KaadmY |
Thanks :D |
| 02:39 |
|
proller joined #minetest-dev |
| 04:49 |
|
Hunterz joined #minetest-dev |
| 05:09 |
|
YuGiOhJCJ joined #minetest-dev |
| 05:10 |
|
nerzhul joined #minetest-dev |
| 05:13 |
|
Karazhan joined #minetest-dev |
| 06:25 |
nerzhul |
hello, i'm pushing a trivial loop cleanup in LBM |
| 07:22 |
|
karamel joined #minetest-dev |
| 07:49 |
|
nerzhul joined #minetest-dev |
| 08:15 |
|
Calinou joined #minetest-dev |
| 09:05 |
|
proller joined #minetest-dev |
| 10:01 |
|
proller__ joined #minetest-dev |
| 10:43 |
|
Raven262 joined #minetest-dev |
| 10:57 |
|
lisac joined #minetest-dev |
| 11:24 |
|
Darcidride joined #minetest-dev |
| 11:34 |
|
Taoki joined #minetest-dev |
| 11:34 |
|
ThomasMonroe joined #minetest-dev |
| 11:36 |
|
CalebDavis joined #minetest-dev |
| 11:52 |
|
Fixer joined #minetest-dev |
| 11:54 |
|
octacian_ joined #minetest-dev |
| 12:13 |
|
twoelk joined #minetest-dev |
| 12:13 |
|
shalmezad joined #minetest-dev |
| 12:13 |
|
proller__ joined #minetest-dev |
| 12:19 |
|
nerzhul joined #minetest-dev |
| 12:57 |
|
RobbieF joined #minetest-dev |
| 12:57 |
|
DS-minetest joined #minetest-dev |
| 13:15 |
|
fireglow[m] left #minetest-dev |
| 13:17 |
|
antims joined #minetest-dev |
| 13:41 |
|
octacian joined #minetest-dev |
| 13:43 |
|
CalebDavis joined #minetest-dev |
| 14:08 |
shalmezad |
So many header files.... feel bad for whoever reviews the merge once I'm done... XD |
| 14:17 |
|
cx384 joined #minetest-dev |
| 14:25 |
|
soupfly joined #minetest-dev |
| 14:27 |
|
octacian_ joined #minetest-dev |
| 14:29 |
|
octacian joined #minetest-dev |
| 14:40 |
|
jin_xi joined #minetest-dev |
| 14:58 |
|
TC01 joined #minetest-dev |
| 15:03 |
|
kaos joined #minetest-dev |
| 15:17 |
|
CalebDavis joined #minetest-dev |
| 15:35 |
|
octacian_ joined #minetest-dev |
| 15:41 |
shalmezad |
Don't suppose anyone knows offhand how to run the linter locally? |
| 15:50 |
sfan5 |
take a look at the travis scripts |
| 15:51 |
|
behalebabo joined #minetest-dev |
| 15:52 |
shalmezad |
Found it, thanks (required setting LINT=1). |
| 15:57 |
nerzhul |
merging #6164 in ~ 5 mins |
| 15:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/6164 -- Clouds API: change speed from 'y' to 'z', ColorSpecs in Lua docs by bendeutsch |
| 16:02 |
nerzhul |
shalmezad, you mean the problem on the pragma once header PR you published ? |
| 16:03 |
nerzhul |
if it's that, run clang-format (3.9 verison minimum) on all problematic files (clang-format -i <file>) when you are at the project root directory |
| 16:03 |
nerzhul |
it will fix errors you added |
| 16:04 |
shalmezad |
Nice, thanks. Also, does travis only run the linter on modified files, or the entire project? (noticed running it showed problems in files I didn't touch) |
| 16:04 |
nerzhul |
yes only the modified files |
| 16:04 |
nerzhul |
and non whitelisted files |
| 16:06 |
shalmezad |
Alright. Will finish it up after work then. Shouldn't take too long. Thanks for helping getting my feet wet with this project. |
| 16:06 |
nerzhul |
take your time :) |
| 16:06 |
nerzhul |
i don't understand why you are angry against the ifndef define endif in every header but pragma once is far more better |
| 16:08 |
shalmezad |
Not angry at all. Just pointed out it wasn't technically standard and wanted to make sure it was ok to make the switch. :) |
| 16:09 |
shalmezad |
That, and it's been a few years since I touched C++ so #pragma once is new to me. |
| 16:10 |
nerzhul |
pragma once is not standard but commonly agreed by eC++11 compilers, then it's standard by usage not by norm :p |
| 16:18 |
shalmezad |
As for changing all the headers, figured if I were doing 8, might as well do the rest for consistency, especially since it's fairly easy once a couple quick vim recordings are defined (one to find first #ifndef to verify it is a headerguard, second to remove current line, next line, insert #pragma once, find last occurrence of #endif, remove). :P |
| 16:40 |
|
Krock joined #minetest-dev |
| 16:50 |
|
DS-minetest joined #minetest-dev |
| 17:22 |
|
octacian joined #minetest-dev |
| 17:30 |
|
jin_xi joined #minetest-dev |
| 17:34 |
|
behalebabo joined #minetest-dev |
| 17:42 |
|
soupfly joined #minetest-dev |
| 17:48 |
|
Hunterz joined #minetest-dev |
| 17:53 |
|
paramat joined #minetest-dev |
| 17:59 |
|
ssieb joined #minetest-dev |
| 18:00 |
|
proller__ joined #minetest-dev |
| 18:00 |
|
CalebDavis joined #minetest-dev |
| 18:05 |
|
cx384 joined #minetest-dev |
| 18:08 |
|
Tmanyo joined #minetest-dev |
| 18:14 |
|
bigfoot547 joined #minetest-dev |
| 18:14 |
|
nerzhul_ joined #minetest-dev |
| 18:27 |
|
RobbieF left #minetest-dev |
| 18:29 |
|
MoNTE48 joined #minetest-dev |
| 18:37 |
|
CalebDavis joined #minetest-dev |
| 18:49 |
|
soupfly joined #minetest-dev |
| 19:04 |
|
shalmezad joined #minetest-dev |
| 19:51 |
KaadmY |
nerzhul: what about the code styling changes for #6165? |
| 19:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/6165 -- Shading by kaadmy |
| 20:59 |
|
proller__ joined #minetest-dev |
| 21:11 |
|
RKINGLEGEND joined #minetest-dev |
| 21:13 |
|
Bobr2 joined #minetest-dev |
| 21:16 |
|
shivajiva joined #minetest-dev |
| 21:46 |
|
TC02 joined #minetest-dev |
| 21:49 |
|
proller joined #minetest-dev |
| 21:54 |
|
proller joined #minetest-dev |
| 22:02 |
|
DI3HARD139 joined #minetest-dev |
| 22:15 |
|
proller__ joined #minetest-dev |
| 22:19 |
|
proller joined #minetest-dev |
| 22:42 |
paramat |
#6167 |
| 22:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/6167 -- Mgv7: Add 'mount_zero_level' parameter by paramat |
| 22:52 |
|
DI3HARD139 joined #minetest-dev |
| 23:08 |
|
jin_xi joined #minetest-dev |
| 23:16 |
|
RichardTheTurd joined #minetest-dev |
| 23:35 |
|
DI3HARD139 joined #minetest-dev |
| 23:44 |
|
Raven262 joined #minetest-dev |
