Time |
Nick |
Message |
00:03 |
|
Noisytoot joined #minetest-dev |
00:05 |
|
Eragon joined #minetest-dev |
00:15 |
MTDiscord |
<luatic> pgimeno: yep, the compiler can. it goes even further and computes sin and cos both at once! https://godbolt.org/z/zoozPh6Mb |
03:01 |
|
TheCoffeMaker joined #minetest-dev |
05:00 |
|
MTDiscord joined #minetest-dev |
06:13 |
|
YuGiOhJCJ joined #minetest-dev |
07:34 |
pgimeno |
luatic: great, thanks for the info |
12:16 |
|
loggingbot_ joined #minetest-dev |
12:16 |
|
Topic for #minetest-dev is now Luanti (fka Minetest) core development and maintenance. Chit chat goes to #minetest. https://dev.minetest.net/ https://irc.minetest.net/ https://github.com/minetest |
16:23 |
[MatrxMT] |
<grorp> since Desour has approved #15614 now, asking sfan5: do you want me to wait for your review? |
16:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/15614 -- In-game settings menu using separate Lua env by grorp |
16:24 |
[MatrxMT] |
<grorp> Zughy has put a meeting note for feature freeze tomorrow 👀 |
16:26 |
[MatrxMT] |
<grorp> one thing to consider with that PR is that it'll need follow-up PRs to be completed, users might ask "why doesn't changing this setting do anything?" otherwise |
16:27 |
[MatrxMT] |
<grorp> on the other hand, if you wait for everything to be ready before even doing the first step, nothing is ever going to happen |
16:29 |
[MatrxMT] |
<grorp> a good compromise could be: merge now so the first step is done, disable the feature for release if necessary (easy to do by replacing the button in the pause menu) |
16:31 |
|
SFENCE joined #minetest-dev |
16:41 |
MTDiscord |
<siliconsniffer> Or add a small note in the pause menu that its still WIP - I'd like to see this in the next release, really great work grorp :D |
16:43 |
|
SFENCE joined #minetest-dev |
18:19 |
MTDiscord |
<luatic> it turns out luanti shot me in the foot approximately 3 years ago but i only realized now. |
19:10 |
[MatrxMT] |
<Zughy> siliconsniffer's suggestion sounds like a great compromise |
19:11 |
[MatrxMT] |
<Zughy> Having to return back to the main menu every time was one of the biggest issues people found out when playing Luanti games at conventions |
19:11 |
celeron55 |
i agree as long as some settings update right away, it's better than not having it |
19:12 |
celeron55 |
there are always obscure things especially to new users, that's not something to be afraid of |
19:13 |
celeron55 |
(as long as it's, let's say, relatively temporary) |
19:13 |
MTDiscord |
<luatic> i agree that if we make the "not everything will work" obvious, it's okay for now |
19:13 |
MTDiscord |
<luatic> in fact it may help us discover some such issues more quickly |
19:14 |
celeron55 |
there will always be settings that don't update without quitting to the menu. even if the engine does it perfect, some mods won't |
19:15 |
MTDiscord |
<herowl> Re settings that don't update right away: game-added custom settings |
19:15 |
MTDiscord |
<luatic> in fact there will be some settings that can't be updated without restarting the game |
19:22 |
celeron55 |
for sure, some game settings might require rolling back so much game state that it doesn't even make sense to do it in any other way than restarting the server |
19:24 |
MTDiscord |
<rollerozxa> the most useful settings for being accessible from the pause menu would be the ones in the categories of primarily client-side settings fwiw |
19:24 |
celeron55 |
it might be beneficial to be able to flag settings in settingtypes.txt as whether updating them requires restarting the game/server or restarting the client |
19:25 |
celeron55 |
then a suitable notice can be shown to the user |
19:25 |
MTDiscord |
<siliconsniffer> Zughy: Yep, totally agree. Finally one can set the mouse sensitivity just right without quitting the game a hundred times :D |
19:25 |
[MatrxMT] |
<grorp> read https://github.com/minetest/minetest/issues/6722#issuecomment-2567014733 already |
19:30 |
[MatrxMT] |
<grorp> (I was annoyed because this felt like a dejavu of nrz's comment on the PR, could have said that more polite) |
19:31 |
[MatrxMT] |
<grorp> *politely |
19:36 |
[MatrxMT] |
<grorp> I agree that siliconsniffer's suggestion sounds good. could reuse some code from #15272 for a warning. |
19:36 |
ShadowBot |
https://github.com/minetest/minetest/issues/15272 -- Show warning in the settings menu when shaders are disabled by grorp |
19:36 |
[MatrxMT] |
<grorp> and thanks |
19:41 |
[ |
you can already change settings without restarting with a CSM, but some settings won't update (I have a patch that makes fov update when set at runtime that I should probably submit) and others will crash (enabling/disabling shaders) |
19:42 |
MTDiscord |
<siliconsniffer> grorp: that's what I thought too, sounds fine to me =) |
22:09 |
|
Desour joined #minetest-dev |
23:33 |
|
panwolfram joined #minetest-dev |
23:42 |
sfan5 |
grorp: feel free to merge |
23:42 |
MTDiscord |
<luatic> 5.11 is gonna be lit |
23:43 |
MTDiscord |
<luatic> goes back to poking in irrlicht's skeletal animation innards |
23:55 |
Desour |
I didn't know ghosts have innards, or bones |